From: Paolo Bonzini <pbonzini@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Brijesh Singh" <brijesh.singh@amd.com>,
"Borislav Petkov" <bp@suse.de>
Subject: Re: [PATCH] KVM: X86: Add missing KVM_AMD dependency
Date: Mon, 8 Oct 2018 13:27:35 +0200 [thread overview]
Message-ID: <c7ae3d1a-5ec0-b2bb-b752-44ea99b1fdcd@redhat.com> (raw)
In-Reply-To: <b489282b-912d-e79d-3b7a-77784b8c51c9@roeck-us.net>
On 06/10/2018 22:43, Guenter Roeck wrote:
>>
>>>> Maybe this works as well? I haven't tested it yet:
>>>>
>>> I am sure there are many possible solutions. I would personally
>>> prefer one
>>> that enforces KVM_AMD=m with CRYPTO_DEV_CCP_DD=m, but that is just me.
>>
>> Well, KVM_AMD=y is a relatively unusual choice to begin with. The
>
> It is common enough that we are not the only ones affected. Also, even a
> "relatively unusual choice" should, in my opinion, not result in a build
> error.
Of course not! The question is whether to solve it by disabling
KVM_AMD_SEV (which is what the current code attempts to do, and my patch
should fix that) or KVM_AMD (your patch).
Paolo
> Never mind, I'll just apply the suggested workaround and configure
> CRYPTO_DEV_CCP_DD=y. I need to do that anyway, after all, if I want to keep
> KVM_AMD=y.
next prev parent reply other threads:[~2018-10-08 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 18:46 [PATCH] KVM: X86: Add missing KVM_AMD dependency Guenter Roeck
2018-10-05 20:41 ` Paolo Bonzini
2018-10-05 22:03 ` Guenter Roeck
2018-10-05 22:18 ` Paolo Bonzini
2018-10-06 20:43 ` Guenter Roeck
2018-10-08 11:27 ` Paolo Bonzini [this message]
2018-10-08 14:52 ` Singh, Brijesh
2018-10-08 17:32 ` Borislav Petkov
2018-10-09 16:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ae3d1a-5ec0-b2bb-b752-44ea99b1fdcd@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox