From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: X86: Add missing KVM_AMD dependency Date: Mon, 8 Oct 2018 13:27:35 +0200 Message-ID: References: <1538765165-19177-1-git-send-email-linux@roeck-us.net> <749a21f9-ad88-af0e-bed7-b505ac57568d@redhat.com> <20181005220325.GA24365@roeck-us.net> <713d35b9-5dd5-284f-b514-7d2295a2db34@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Brijesh Singh , Borislav Petkov To: Guenter Roeck Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/10/2018 22:43, Guenter Roeck wrote: >> >>>> Maybe this works as well?  I haven't tested it yet: >>>> >>> I am sure there are many possible solutions. I would personally >>> prefer one >>> that enforces KVM_AMD=m with CRYPTO_DEV_CCP_DD=m, but that is just me. >> >> Well, KVM_AMD=y is a relatively unusual choice to begin with.  The > > It is common enough that we are not the only ones affected. Also, even a > "relatively unusual choice" should, in my opinion, not result in a build > error. Of course not! The question is whether to solve it by disabling KVM_AMD_SEV (which is what the current code attempts to do, and my patch should fix that) or KVM_AMD (your patch). Paolo > Never mind, I'll just apply the suggested workaround and configure > CRYPTO_DEV_CCP_DD=y. I need to do that anyway, after all, if I want to keep > KVM_AMD=y.