From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
mtosatti@redhat.com,
"Pedro Principeza" <pedro.principeza@canonical.com>,
"kvm list" <kvm@vger.kernel.org>,
libvir-list@redhat.com,
"Dann Frazier" <dann.frazier@canonical.com>,
"Guilherme Piccoli" <gpiccoli@canonical.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Christian Ehrhardt" <christian.ehrhardt@canonical.com>,
qemu-devel@nongnu.org, "Mohammed Gamal" <mgamal@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
fw@gpiccoli.net, rth@twiddle.net
Subject: Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it
Date: Fri, 10 Jul 2020 09:21:34 +0200 [thread overview]
Message-ID: <c81254b6-e6ae-9d2e-917c-4ce42c8baab0@redhat.com> (raw)
In-Reply-To: <CALMp9eQnrdu-9sZhW3aXpK4pizOW=8G=bj1wkumSgHVNfG=CbQ@mail.gmail.com>
On 09/07/20 19:00, Jim Mattson wrote:
>>
>> Mostly fine. Some edge cases, like different page fault errors for
>> addresses above GUEST_MAXPHYADDR and below HOST_MAXPHYADDR. Which I
>> think Mohammed fixed in the kernel recently.
> Doesn't this require intercepting MOV-to-CR3 when the guest is in PAE
> mode, so that the hypervisor can validate the high bits in the PDPTEs?
In theory yes, but in practice it just means we'd use the AMD behavior
of loading guest PDPT entries on demand during address translation
(because the PDPT would point to nonexistent memory and cause an EPT
violation on the PDE).
Paolo
prev parent reply other threads:[~2020-07-10 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 15:53 [PATCH 0/2] kvm: x86/cpu: Support guest MAXPHYADDR < host MAXPHYADDR Mohammed Gamal
2020-06-19 15:53 ` [PATCH 1/2] kvm: Add support for KVM_CAP_HAS_SMALLER_MAXPHYADDR Mohammed Gamal
2020-06-19 15:53 ` [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it Mohammed Gamal
2020-06-19 16:25 ` Paolo Bonzini
2020-07-08 17:16 ` Eduardo Habkost
2020-07-08 17:26 ` Daniel P. Berrangé
2020-07-09 9:44 ` Gerd Hoffmann
2020-07-09 9:55 ` Mohammed Gamal
2020-07-09 10:11 ` Paolo Bonzini
2020-07-09 17:00 ` Jim Mattson
2020-07-09 19:13 ` Eduardo Habkost
2020-07-10 7:22 ` Paolo Bonzini
2020-07-10 16:02 ` Eduardo Habkost
2020-07-10 16:49 ` Paolo Bonzini
2020-07-10 7:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81254b6-e6ae-9d2e-917c-4ce42c8baab0@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dann.frazier@canonical.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fw@gpiccoli.net \
--cc=gpiccoli@canonical.com \
--cc=jmattson@google.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mgamal@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pedro.principeza@canonical.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox