From: Thomas Huth <thuth@redhat.com>
To: Nico Boehr <nrb@linux.ibm.com>,
frankja@linux.ibm.com, imbrenda@linux.ibm.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v6 8/8] lib: s390x: interrupt: remove TEID_ASCE defines
Date: Mon, 4 Sep 2023 12:39:21 +0200 [thread overview]
Message-ID: <c81706fb-5e90-d431-2f6d-07c1f328e7ed@redhat.com> (raw)
In-Reply-To: <20230904082318.1465055-9-nrb@linux.ibm.com>
On 04/09/2023 10.22, Nico Boehr wrote:
> These defines were - I can only guess - ment for the asce_id field.
s/ment/meant/
> Since print_decode_teid() used AS_PRIM and friends instead, I see little
> benefit in keeping these around.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> lib/s390x/asm/interrupt.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/lib/s390x/asm/interrupt.h b/lib/s390x/asm/interrupt.h
> index 7f73d473b346..48bd78fa1515 100644
> --- a/lib/s390x/asm/interrupt.h
> +++ b/lib/s390x/asm/interrupt.h
> @@ -13,11 +13,6 @@
> #define EXT_IRQ_EXTERNAL_CALL 0x1202
> #define EXT_IRQ_SERVICE_SIG 0x2401
>
> -#define TEID_ASCE_PRIMARY 0
> -#define TEID_ASCE_AR 1
> -#define TEID_ASCE_SECONDARY 2
> -#define TEID_ASCE_HOME 3
> -
> union teid {
> unsigned long val;
> union {
With the nit fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2023-09-04 10:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 8:22 [kvm-unit-tests PATCH v6 0/8] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 1/8] lib: s390x: introduce bitfield for PSW mask Nico Boehr
2023-09-04 9:49 ` Thomas Huth
2023-09-05 12:22 ` Janosch Frank
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 2/8] s390x: add function to set DAT mode for all interrupts Nico Boehr
2023-09-04 9:54 ` Thomas Huth
2023-09-05 12:26 ` Janosch Frank
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 3/8] s390x: sie: switch to home space mode before entering SIE Nico Boehr
2023-09-04 9:59 ` Thomas Huth
2023-09-04 11:07 ` Nico Boehr
2023-09-04 11:40 ` Thomas Huth
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 4/8] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 5/8] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 6/8] s390x: add test source dir to include paths Nico Boehr
2023-09-04 10:37 ` Thomas Huth
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 7/8] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-09-05 13:45 ` Janosch Frank
2023-09-04 8:22 ` [kvm-unit-tests PATCH v6 8/8] lib: s390x: interrupt: remove TEID_ASCE defines Nico Boehr
2023-09-04 10:39 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81706fb-5e90-d431-2f6d-07c1f328e7ed@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox