public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Mark Brown <broonie@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
	kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix build of rseq test
Date: Wed, 18 Jan 2023 09:30:01 -0500	[thread overview]
Message-ID: <c8901eb2-bee5-a7b3-cd43-ace970754ade@efficios.com> (raw)
In-Reply-To: <Y8f2HA02BJNYUYc7@sirena.org.uk>

On 2023-01-18 08:37, Mark Brown wrote:
> On Fri, Jan 06, 2023 at 07:24:19PM +0000, Mark Brown wrote:
> 
>> The KVM rseq test is failing to build in -next due to a commit merged
>> from the tip tree which adds a wrapper for sys_getcpu() to the rseq
>> kselftests, conflicting with the wrapper already included in the KVM
>> selftest:
> 
> Any thoughts on this?  The KVM tests are still failing to build
> in -next:

I'm OK with the fix you submitted in this email thread. Should it be 
routed through -tip ?

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Thanks,

Mathieu

> 
> rseq_test.c:48:13: error: conflicting types for ‘sys_getcpu’
>     48 | static void sys_getcpu(unsigned *cpu)
>        |             ^~~~~~~~~~
> In file included from rseq_test.c:23:
> ../rseq/rseq.c:82:12: note: previous definition of ‘sys_getcpu’ was here
>     82 | static int sys_getcpu(unsigned *cpu, unsigned *node)
>        |            ^~~~~~~~~~
> 
> https://storage.kernelci.org/next/master/next-20230118/arm64/defconfig/gcc-10/logs/kselftest.log

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com


  reply	other threads:[~2023-01-18 14:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 19:24 [PATCH] KVM: selftests: Fix build of rseq test Mark Brown
2023-01-18 13:37 ` Mark Brown
2023-01-18 14:30   ` Mathieu Desnoyers [this message]
2023-01-18 14:44     ` Mark Brown
2023-01-18 14:46       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8901eb2-bee5-a7b3-cd43-ace970754ade@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=broonie@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox