From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E871745C18 for ; Wed, 11 Sep 2024 09:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726047705; cv=none; b=ALUN86mdROAVax+ITevYBFf2HPGslHibi0S4qGjUplDYfDaVsqLKZi5xhaA7YF18cTCsmTdEmhp1OgYoB2oNVXa7IAYposyGaOv9oRndICnyVOT2c0KFhY92cnJs27lmWA9VrHm5BvilMSz8JXYE5jdwQCw9lBpT3yjsry7jNmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726047705; c=relaxed/simple; bh=H4B9/uwNGKt/vZ/gpS8GV45FGQDVPOnLe+0SZOwtc7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GIecjkiCq+tPQFU5WG2yccwCh70nx3tq8A8e24Dy49uDFtnS8BOwInS+Q3hr9kHx/B9XRz0xAmjeA9rAMvvNs3HcVjmNn0M1Leu9nXqpbNHEsNma8VqfWTdvcjqmKOys+7O8NGIf07v25ZU/n/tgZasYAoC6DWj/MR2qdL65C3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=GHCBuvZo; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="GHCBuvZo" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2055136b612so79336745ad.0 for ; Wed, 11 Sep 2024 02:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1726047703; x=1726652503; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kn5qlxz6rYEqhaF1IlMFBCOQtR9IuIiaMxxsFKOJnss=; b=GHCBuvZot0HExvOp+kRJdqwN6bev7E1IWXilTrpw+YvbVa2Lh/EJ9gwKDShjKrDyRQ b7hgtZ/xskrFuF+p5gBrOgxbExx36Mqyi9hfgvNi6M9qx3AUHDRcXNh0+Yx2CPWlfUSf VWtbFn6cAZiaz6Y37pVmwbfSLhm79cfnriMQrBA/Vaq3ISYczTklFjqcQpTi/OEVgGUs jStlAbOUUms4Lo7bPLExFFPMNELPqv9Af0VzrKAlwOJMDTtM+RXkEOKnsx0AK7HOjIk6 atljVe3yPKmB43wx0My1yzSvbu6dql836CXvLRLArUgM30BxMMsnH825WpdKutm47V4z Gxlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726047703; x=1726652503; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kn5qlxz6rYEqhaF1IlMFBCOQtR9IuIiaMxxsFKOJnss=; b=EaXrurgE/J0EVTwWxHTgkodWjK/pZ3WhNZjkAxvKb9KRG9h1a+Kd+tSEFNFnwP+pJQ s6opFmPrxVLfFN+GNckmHouTYtX7xnArXg8wLWDv28kLo7RsSzPHhcdr5EGeaNmARLWe tfkvgWH22DQfYQlntF2dOC5eU/IY2cNcHZCDynxTAfIxxVKDn9Fpnuy49sVQPOIyajT0 TUV5zSb0Dqeg2nz/0acSUueOKwZMAK/lil1gJKAqEKF+TYJ7ziGoYFd8QudMVceMQe1k HQRqL3thQqQWW445hSxcYR0tv60OCXs6kf/47P4231QDuCoJ0QySP60w5b/55bn2/1xm Or0g== X-Forwarded-Encrypted: i=1; AJvYcCUUBco2VK4aFaKUtNpIv3GdAO9++7R8z7tWDePYSlk+BhVdy2l6Lbuopgr7y1nF28JIKbg=@vger.kernel.org X-Gm-Message-State: AOJu0YzSOErmXcXzig+eEgaPkmeqs9fOsHslXGiT3RxwunbcH8+5CvCx ZdIkVmMq+j5hTSwGYlKRpcw3UViwIhkkjNsgC8Kfh0y9BBB4Be/2rqLlDnYfGeI= X-Google-Smtp-Source: AGHT+IG7rMRmLj/y96aXDOZLOEvKG9GOrb7S5g+4beGqyo1xcxzviLsaVZV/GqWsQoagVaROIUgcuw== X-Received: by 2002:a17:902:f790:b0:202:19a0:fcba with SMTP id d9443c01a7336-2074c6a4573mr64727285ad.41.1726047703192; Wed, 11 Sep 2024 02:41:43 -0700 (PDT) Received: from [192.168.68.110] (201-68-240-198.dsl.telesp.net.br. [201.68.240.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e321fdsm60213095ad.83.2024.09.11.02.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 02:41:42 -0700 (PDT) Message-ID: Date: Wed, 11 Sep 2024 06:41:28 -0300 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/39] hw/ppc: replace assert(false) with g_assert_not_reached() To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Zhao Liu , "Richard W.M. Jones" , Joel Stanley , Kevin Wolf , Paolo Bonzini , qemu-arm@nongnu.org, Corey Minyard , Eric Farman , Thomas Huth , Keith Busch , WANG Xuerui , Hyman Huang , Stefan Berger , Michael Rolnik , Alistair Francis , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Markus Armbruster , Sriram Yagnaraman , Palmer Dabbelt , qemu-riscv@nongnu.org, Ani Sinha , Halil Pasic , Jesper Devantier , Laurent Vivier , Peter Maydell , Igor Mammedov , kvm@vger.kernel.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Richard Henderson , Fam Zheng , qemu-s390x@nongnu.org, Hanna Reitz , Nicholas Piggin , Eduardo Habkost , Laurent Vivier , Rob Herring , Marcel Apfelbaum , qemu-block@nongnu.org, "Maciej S. Szmigiero" , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Christian Borntraeger , Harsh Prateek Bora , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Nina Schoetterl-Glausch , "Michael S. Tsirkin" , Fabiano Rosas , Helge Deller , Dmitry Fleytman , Akihiko Odaki , Marcelo Tosatti , David Gibson , Aurelien Jarno , Liu Zhiwei , Yanan Wang , Peter Xu , Bin Meng , Weiwei Li , Klaus Jensen , Jean-Christophe Dubois , Jason Wang References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> <20240910221606.1817478-21-pierrick.bouvier@linaro.org> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20240910221606.1817478-21-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/10/24 7:15 PM, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- Reviewed-by: Daniel Henrique Barboza > hw/ppc/spapr_events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c > index cb0eeee5874..38ac1cb7866 100644 > --- a/hw/ppc/spapr_events.c > +++ b/hw/ppc/spapr_events.c > @@ -645,7 +645,7 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, > /* we shouldn't be signaling hotplug events for resources > * that don't support them > */ > - g_assert(false); > + g_assert_not_reached(); > return; > } >