public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: avi@qumranet.com
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: [PATCH 3 of 5] KVM: ppc: Remove unmatched kunmap() call
Date: Wed, 21 May 2008 18:22:53 -0500	[thread overview]
Message-ID: <ca75eeec3fea1cc3f45b.1211412173@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1211412170@localhost.localdomain>

We're not calling kmap() now, so we shouldn't call kunmap() either. This has no
practical effect in the non-highmem case, which is why it hasn't caused more
obvious problems.

Pointed out by Anthony Liguori.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/arch/powerpc/kvm/44x_tlb.c b/arch/powerpc/kvm/44x_tlb.c
--- a/arch/powerpc/kvm/44x_tlb.c
+++ b/arch/powerpc/kvm/44x_tlb.c
@@ -116,8 +116,6 @@ static void kvmppc_44x_shadow_release(st
 	struct tlbe *stlbe = &vcpu->arch.shadow_tlb[index];
 	struct page *page = vcpu->arch.shadow_pages[index];
 
-	kunmap(vcpu->arch.shadow_pages[index]);
-
 	if (get_tlb_v(stlbe)) {
 		if (kvmppc_44x_tlbe_is_writable(stlbe))
 			kvm_release_page_dirty(page);

  parent reply	other threads:[~2008-05-21 23:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 23:22 [PATCH 0 of 5] PowerPC KVM fixes for 2.6.26 Hollis Blanchard
2008-05-21 23:22 ` [PATCH 1 of 5] KVM: ppc: Remove duplicate function Hollis Blanchard
2008-05-21 23:22 ` [PATCH 2 of 5] KVM: ppc: add lwzx/stwz emulation Hollis Blanchard
2008-05-21 23:22 ` Hollis Blanchard [this message]
2008-05-21 23:22 ` [PATCH 4 of 5] KVM: ppc: Use a read lock around MMU operations, and release it on error Hollis Blanchard
2008-05-21 23:22 ` [PATCH 5 of 5] [kvm powerpc] Report bad GFNs Hollis Blanchard
2008-05-22  2:47   ` Anthony Liguori
2008-05-22 14:02     ` Hollis Blanchard
2008-05-25 10:35 ` [PATCH 0 of 5] PowerPC KVM fixes for 2.6.26 Avi Kivity
2008-05-27 15:39   ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca75eeec3fea1cc3f45b.1211412173@localhost.localdomain \
    --to=hollisb@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox