From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CA3C77B61 for ; Mon, 1 May 2023 12:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232602AbjEAMmy (ORCPT ); Mon, 1 May 2023 08:42:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231736AbjEAMmx (ORCPT ); Mon, 1 May 2023 08:42:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19DFD1984 for ; Mon, 1 May 2023 05:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682944879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5GiG3wgCtX7mYiiVucX+fm0QBMXAYWeAETD8YBMKgWA=; b=Rp+XiTpvPeQPyH35YUn1jTIZxA9YFU/JCzWzg6PSZbFM4oncTIHxCl4pGDy2rFn+2IOy8e gHyzRQ1deneyRc5WarQfawBuzL87bXAhpujqkcoY5g0ygfIe10/8B9uOkNPn/ZhHu7fbfq JNCHp3rDS3HLQP6Tx7ZcGykSPoG8sF4= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-CRq8oyqQPY2RQ4-66J8mOg-1; Mon, 01 May 2023 08:41:18 -0400 X-MC-Unique: CRq8oyqQPY2RQ4-66J8mOg-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1a687e3de0aso2717745ad.1 for ; Mon, 01 May 2023 05:41:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682944877; x=1685536877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GiG3wgCtX7mYiiVucX+fm0QBMXAYWeAETD8YBMKgWA=; b=BrJ+3nN3GVyLbz1zaiF5HRyHFyPm0IFs4OLszB6vBHV831wErd+43nIQXURo6jRrJW Rq5tBHcE3j6rW37NWXOr46ML9Y+emr1waocmHuxWy4Tx1+PKkPCiHedcytac+5UPw3Tn 6oBUQmk5NRz/PwpxPXocIp04uesNrl56EjJErkVq6d+oPcX0VxGcwSnd8PQlzCArzOOd 0OW/V9dxC+HHFVGPNMKASJaPbnYSRboJYoqLbyI9lL+7Pzad4A8ue0q9f9gTv9iqsI/A hRXAo3RWV9GUN1GawmbHVzNQil1Aj7BqaDWHaASqIgKgUZR9ITGAbgQ1wkt/PVzL6NSi pD7Q== X-Gm-Message-State: AC+VfDwFjm/p1gCOQ2Jkug1ajaKajLJyn3ou2xBudob+bDapESY5F25+ +K+KaCLdEobter1ydLnq+TCJBmNJoT8PUemgNRr+h32D7WkekawItIoymdL/FvpnyG7OX4XMJ/t TYbX89/VtS090teLw6fI5Vebwpw== X-Received: by 2002:a17:902:e552:b0:19e:94ff:6780 with SMTP id n18-20020a170902e55200b0019e94ff6780mr16850187plf.6.1682944877720; Mon, 01 May 2023 05:41:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ40lpkbv20+infGM250AeSLajOiHyKpZ5m9hTq4ni8edFaK8Bivm1le2WH1iZrohAhApnCSsw== X-Received: by 2002:a17:902:e552:b0:19e:94ff:6780 with SMTP id n18-20020a170902e55200b0019e94ff6780mr16850167plf.6.1682944877431; Mon, 01 May 2023 05:41:17 -0700 (PDT) Received: from [10.66.61.39] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id bh7-20020a170902a98700b001a19cf1b37esm17834548plb.40.2023.05.01.05.41.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 May 2023 05:41:17 -0700 (PDT) Message-ID: Date: Mon, 1 May 2023 20:41:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [kvm-unit-tests PATCH v5 01/29] lib: Move acpi header and implementation to lib Content-Language: en-US To: Nikos Nikoleris , kvm@vger.kernel.org, kvmarm@lists.linux.dev, andrew.jones@linux.dev Cc: pbonzini@redhat.com, alexandru.elisei@arm.com, ricarkol@google.com References: <20230428120405.3770496-1-nikos.nikoleris@arm.com> <20230428120405.3770496-2-nikos.nikoleris@arm.com> From: Shaoqin Huang In-Reply-To: <20230428120405.3770496-2-nikos.nikoleris@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 4/28/23 20:03, Nikos Nikoleris wrote: > Move acpi.h to lib to make it available for other architectures. > > Signed-off-by: Nikos Nikoleris Reviewed-by: Shaoqin Huang > --- > x86/Makefile.common | 2 +- > lib/x86/asm/setup.h | 2 +- > lib/{x86 => }/acpi.h | 4 ++-- > lib/{x86 => }/acpi.c | 0 > x86/s3.c | 2 +- > x86/vmexit.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > rename lib/{x86 => }/acpi.h (99%) > rename lib/{x86 => }/acpi.c (100%) > > diff --git a/x86/Makefile.common b/x86/Makefile.common > index 365e199f..9f2bc93f 100644 > --- a/x86/Makefile.common > +++ b/x86/Makefile.common > @@ -2,6 +2,7 @@ > > all: directories test_cases > > +cflatobjs += lib/acpi.o > cflatobjs += lib/pci.o > cflatobjs += lib/pci-edu.o > cflatobjs += lib/alloc.o > @@ -18,7 +19,6 @@ cflatobjs += lib/x86/apic.o > cflatobjs += lib/x86/atomic.o > cflatobjs += lib/x86/desc.o > cflatobjs += lib/x86/isr.o > -cflatobjs += lib/x86/acpi.o > cflatobjs += lib/x86/stack.o > cflatobjs += lib/x86/fault_test.o > cflatobjs += lib/x86/delay.o > diff --git a/lib/x86/asm/setup.h b/lib/x86/asm/setup.h > index 1f384274..458eac85 100644 > --- a/lib/x86/asm/setup.h > +++ b/lib/x86/asm/setup.h > @@ -4,7 +4,7 @@ > unsigned long setup_tss(u8 *stacktop); > > #ifdef CONFIG_EFI > -#include "x86/acpi.h" > +#include "acpi.h" > #include "x86/apic.h" > #include "x86/processor.h" > #include "x86/smp.h" > diff --git a/lib/x86/acpi.h b/lib/acpi.h > similarity index 99% > rename from lib/x86/acpi.h > rename to lib/acpi.h > index 67ba3899..1e89840c 100644 > --- a/lib/x86/acpi.h > +++ b/lib/acpi.h > @@ -1,5 +1,5 @@ > -#ifndef _X86_ACPI_H_ > -#define _X86_ACPI_H_ > +#ifndef _ACPI_H_ > +#define _ACPI_H_ > > #include "libcflat.h" > > diff --git a/lib/x86/acpi.c b/lib/acpi.c > similarity index 100% > rename from lib/x86/acpi.c > rename to lib/acpi.c > diff --git a/x86/s3.c b/x86/s3.c > index 6e41d0c4..378d37ae 100644 > --- a/x86/s3.c > +++ b/x86/s3.c > @@ -1,5 +1,5 @@ > #include "libcflat.h" > -#include "x86/acpi.h" > +#include "acpi.h" > #include "asm/io.h" > > static u32* find_resume_vector_addr(void) > diff --git a/x86/vmexit.c b/x86/vmexit.c > index 2e8866e1..9260accc 100644 > --- a/x86/vmexit.c > +++ b/x86/vmexit.c > @@ -1,9 +1,9 @@ > #include "libcflat.h" > +#include "acpi.h" > #include "smp.h" > #include "pci.h" > #include "x86/vm.h" > #include "x86/desc.h" > -#include "x86/acpi.h" > #include "x86/apic.h" > #include "x86/isr.h" > -- Shaoqin