From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH 3/3] tests: don't call setup_idt() if with smp_init() Date: Tue, 25 Oct 2016 18:00:58 +0200 Message-ID: References: <1477386030-13955-1-git-send-email-peterx@redhat.com> <1477386030-13955-4-git-send-email-peterx@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: drjones@redhat.com, rkrcmar@redhat.com To: Peter Xu , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbcJYQBE (ORCPT ); Tue, 25 Oct 2016 12:01:04 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0354CC03BD68 for ; Tue, 25 Oct 2016 16:01:04 +0000 (UTC) In-Reply-To: <1477386030-13955-4-git-send-email-peterx@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 25/10/2016 11:00, Peter Xu wrote: > smp_init() will setup idt as default. No need to call it twice. > > Signed-off-by: Peter Xu > --- > x86/apic.c | 1 - > x86/hyperv_stimer.c | 1 - > x86/hyperv_synic.c | 1 - > x86/ioapic.c | 1 - > x86/tscdeadline_latency.c | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/x86/apic.c b/x86/apic.c > index fefb584..eff9a11 100644 > --- a/x86/apic.c > +++ b/x86/apic.c > @@ -393,7 +393,6 @@ int main() > { > setup_vm(); > smp_init(); > - setup_idt(); > > test_lapic_existence(); > > diff --git a/x86/hyperv_stimer.c b/x86/hyperv_stimer.c > index 6382938..5292523 100644 > --- a/x86/hyperv_stimer.c > +++ b/x86/hyperv_stimer.c > @@ -330,7 +330,6 @@ static void stimer_test_all(void) > > setup_vm(); > smp_init(); > - setup_idt(); > enable_apic(); > > handle_irq(SINT1_VEC, stimer_isr); > diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c > index 3f98c42..74bbd58 100644 > --- a/x86/hyperv_synic.c > +++ b/x86/hyperv_synic.c > @@ -154,7 +154,6 @@ int main(int ac, char **av) > > setup_vm(); > smp_init(); > - setup_idt(); > enable_apic(); > > synic_prepare_sint_vecs(); > diff --git a/x86/ioapic.c b/x86/ioapic.c > index a554e43..314c9bb 100644 > --- a/x86/ioapic.c > +++ b/x86/ioapic.c > @@ -398,7 +398,6 @@ int main(void) > { > setup_vm(); > smp_init(); > - setup_idt(); > > mask_pic_interrupts(); > > diff --git a/x86/tscdeadline_latency.c b/x86/tscdeadline_latency.c > index 0592802..0617a1b 100644 > --- a/x86/tscdeadline_latency.c > +++ b/x86/tscdeadline_latency.c > @@ -106,7 +106,6 @@ int main(int argc, char **argv) > > setup_vm(); > smp_init(); > - setup_idt(); > > test_lapic_existence(); > > ... and patch 3 too. Paolo