From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v3 10/12] KVM: s390: activate GISA for emulated interrupts Date: Thu, 25 Jan 2018 18:38:35 +0100 Message-ID: References: <20180125170608.38276-1-borntraeger@de.ibm.com> <20180125170608.38276-5-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: KVM , linux-s390 , Janosch Frank , Michael Mueller To: Christian Borntraeger , Cornelia Huck Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53362 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbeAYRii (ORCPT ); Thu, 25 Jan 2018 12:38:38 -0500 In-Reply-To: <20180125170608.38276-5-borntraeger@de.ibm.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 25.01.2018 18:06, Christian Borntraeger wrote: > From: Michael Mueller > > If the AIV facility is available, a GISA will be used to manage emulated > adapter interrupts. > > Signed-off-by: Michael Mueller > Reviewed-by: Halil Pasic > Reviewed-by: Christian Borntraeger > Signed-off-by: Christian Borntraeger > --- > arch/s390/kvm/interrupt.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c > index 1a561ad..ec4b7bf 100644 > --- a/arch/s390/kvm/interrupt.c > +++ b/arch/s390/kvm/interrupt.c > @@ -2840,7 +2840,13 @@ void kvm_s390_gisa_clear(struct kvm *kvm) > > void kvm_s390_gisa_init(struct kvm *kvm) > { > - /* not implemented yet */ > + if (!css_general_characteristics.aiv) > + kvm->arch.gisa = NULL; > + else { Hmm, isn't it NULL as default? if (css_general_characteristics.aiv) { ... Anyhow, Reviewed-by: David Hildenbrand > + kvm->arch.gisa = &kvm->arch.sie_page2->gisa; > + VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa); > + kvm_s390_gisa_clear(kvm); > + } > } > > void kvm_s390_gisa_destroy(struct kvm *kvm) > -- Thanks, David / dhildenb