From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Date: Thu, 23 Aug 2018 18:26:40 +0200 Message-ID: References: <20180823162424.13282-1-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jim Mattson , linux-kernel@vger.kernel.org To: Vitaly Kuznetsov , kvm@vger.kernel.org Return-path: In-Reply-To: <20180823162424.13282-1-vkuznets@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 23/08/2018 18:24, Vitaly Kuznetsov wrote: > nested_run_pending is set 20 lines above and check_vmentry_prereqs()/ > check_vmentry_postreqs() don't seem to be resetting it (the later, however, > checks it). > > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/kvm/vmx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 6c3514750d0c..8a63b8cf9458 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu, > check_vmentry_postreqs(vcpu, vmcs12, &exit_qual)) > return -EINVAL; > > - if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING) > - vmx->nested.nested_run_pending = 1; > - > vmx->nested.dirty_vmcs12 = true; > ret = enter_vmx_non_root_mode(vcpu, NULL); > if (ret) > Reviewed-by: Paolo Bonzini