From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CC9C433E6 for ; Thu, 14 Jan 2021 02:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822BF23442 for ; Thu, 14 Jan 2021 02:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729397AbhANB7v (ORCPT ); Wed, 13 Jan 2021 20:59:51 -0500 Received: from mga05.intel.com ([192.55.52.43]:52821 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729378AbhANB7r (ORCPT ); Wed, 13 Jan 2021 20:59:47 -0500 IronPort-SDR: YsryFXQNNo40CS64TKDr93tsFvQdfRTUCg+X3rz/uq6zVQ55p7imKzJ2nbB8neU5XtUHX09ADf zJgD9yWwW1gg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="263086146" X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="263086146" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 17:58:59 -0800 IronPort-SDR: KROhvZylfWMrAJyjWdB9MBI6G5CCmZmiATzs+GnldWjGPwXsvos6tq/eauIXuMzjSsNgMONA+b DSFG90SkgDVQ== X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="353704460" Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.238.4.93]) ([10.238.4.93]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 17:58:54 -0800 Subject: Re: [PATCH v3 03/17] KVM: x86/pmu: Introduce the ctrl_mask value for fixed counter To: Peter Zijlstra , Like Xu Cc: Paolo Bonzini , eranian@google.com, kvm@vger.kernel.org, Ingo Molnar , Sean Christopherson , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andi Kleen , Kan Liang , wei.w.wang@intel.com, luwei.kang@intel.com, linux-kernel@vger.kernel.org References: <20210104131542.495413-1-like.xu@linux.intel.com> <20210104131542.495413-4-like.xu@linux.intel.com> From: "Xu, Like" Message-ID: Date: Thu, 14 Jan 2021 09:58:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021/1/14 2:06, Peter Zijlstra wrote: > On Mon, Jan 04, 2021 at 09:15:28PM +0800, Like Xu wrote: >> @@ -327,6 +328,7 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu) >> pmu->counter_bitmask[KVM_PMC_FIXED] = 0; >> pmu->version = 0; >> pmu->reserved_bits = 0xffffffff00200000ull; >> + pmu->fixed_ctr_ctrl_mask = ~0ull; > All 1s > >> >> entry = kvm_find_cpuid_entry(vcpu, 0xa, 0); >> if (!entry) >> @@ -358,6 +360,9 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu) >> ((u64)1 << edx.split.bit_width_fixed) - 1; >> } >> >> + for (i = 0; i < pmu->nr_arch_fixed_counters; i++) >> + pmu->fixed_ctr_ctrl_mask |= (0xbull << (i * 4)); > With some extra 1s on top You're right, I think it should be:     pmu->fixed_ctr_ctrl_mask &= ~(0xbull << (i * 4)); w/o invertion and I will fix it in the next version. > >> + pmu->fixed_ctr_ctrl_mask = ~pmu->fixed_ctr_ctrl_mask; > Inverted is all 0s, always. > >> pmu->global_ctrl = ((1ull << pmu->nr_arch_gp_counters) - 1) | >> (((1ull << pmu->nr_arch_fixed_counters) - 1) << INTEL_PMC_IDX_FIXED); >> pmu->global_ctrl_mask = ~pmu->global_ctrl; >> -- >> 2.29.2 >>