From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [qemu patch 2/2] kvmclock: reduce kvmclock difference on
 migration
Date: Mon, 14 Nov 2016 17:43:33 +0100
Message-ID: <cbcac3d2-88aa-3cb4-7257-e70061a22a2c@redhat.com>
References: <20161114123628.703911091@redhat.com>
 <20161114123700.158592605@redhat.com>
 <a3e00c38-4d4d-d353-231d-9eb0233139e2@redhat.com>
 <20161114140028.GA25935@amt.cnet>
 <62d634ab-70ad-4be7-1622-f2e3a9d865fe@redhat.com>
 <20161114145054.GA28663@amt.cnet>
 <67bffd95-2e4e-7273-c154-a3fdfe622387@redhat.com>
 <20161114154015.GA30048@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        Juan Quintela <quintela@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Eduardo Habkost <ehabkost@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33260 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752253AbcKNQnh (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 11:43:37 -0500
Received: by mail-wm0-f66.google.com with SMTP id u144so16856110wmu.0
        for <kvm@vger.kernel.org>; Mon, 14 Nov 2016 08:43:36 -0800 (PST)
In-Reply-To: <20161114154015.GA30048@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 14/11/2016 16:40, Marcelo Tosatti wrote:
> static bool kvmclock_src_use_reliable_get_clock(void *opaque)
> {
>     KVMClockState *s = opaque;
> 
>     /*
>      * On machine types that support reliable KVM_GET_CLOCK,
>      * if host kernel does provide reliable KVM_GET_CLOCK,
>      * set src_use_reliable_get_clock=true so that destination
>      * avoids reading kvmclock from memory.
>      */
>     if (s->mach_use_reliable_get_clock && kvm_has_adjust_clock_stable())
>     {
>         s->src_use_reliable_get_clock = true;
>     }
> 
>     return s->mach_use_reliable_get_clock;
> }
> 
> 
> Ah, OK, done.

s->src_use_reliable_get_clock should not be set with
KVM_CHECK_EXTENSION, but rather from the flags returned by KVM_GET_CLOCK.

> So s->src_use_reliable_get_clock is only used to indicate 
> to the destination that: "you can use KVM_GET_CLOCK value, 
> its safe".

Yes, we agree.  I was listing all the points, not just those where we
disagree.  Actually I'm not sure where we disagree, except on using
flags from KVM_CHECK_EXTENSION vs. flags from KVM_GET_CLOCK...

Paolo