From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Gonda <pgonda@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, seanjc@google.com
Subject: Re: [PATCH 4/4] KVM: SEV: Do COPY_ENC_CONTEXT_FROM with both VMs locked
Date: Wed, 17 Nov 2021 19:27:10 +0100 [thread overview]
Message-ID: <cbcce032-abfb-7fdc-74bb-0f4a29010c30@redhat.com> (raw)
In-Reply-To: <CAMkAt6odbAGZ-LgK7yefnNRgoAAs3ekvR2_sZpjTiv_6mfwRKg@mail.gmail.com>
On 11/17/21 18:46, Peter Gonda wrote:
>> + if (dst_kvm == src_kvm)
>> + return -EINVAL;
>> +
> Worth adding a migrate/mirror from self fails tests in
> test_sev_(migrate|mirror)_parameters()? I guess it's already covered
> by "the source cannot be SEV enabled" test cases.
>
It was covered by the locking test (which does not check i != j).
There's no equivalent for the operation of creating a mirror VM, I can
add it in v2.
Paolo
prev parent reply other threads:[~2021-11-17 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 16:38 [PATCH 0/4] MOVE/COPY_ENC_CONTEXT_FROM locking cleanup and tests Paolo Bonzini
2021-11-17 16:38 ` [PATCH 1/4] selftests: sev_migrate_tests: free all VMs Paolo Bonzini
2021-11-17 16:52 ` Peter Gonda
2021-11-17 18:24 ` Paolo Bonzini
2021-11-17 16:38 ` [PATCH 2/4] selftests: sev_migrate_tests: add tests for KVM_CAP_VM_COPY_ENC_CONTEXT_FROM Paolo Bonzini
2021-11-17 17:03 ` Peter Gonda
2021-11-22 19:52 ` Sean Christopherson
2021-11-17 16:38 ` [PATCH 3/4] KVM: SEV: cleanup locking for KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM Paolo Bonzini
2021-11-17 17:47 ` Peter Gonda
2021-11-17 16:38 ` [PATCH 4/4] KVM: SEV: Do COPY_ENC_CONTEXT_FROM with both VMs locked Paolo Bonzini
2021-11-17 17:46 ` Peter Gonda
2021-11-17 18:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbcce032-abfb-7fdc-74bb-0f4a29010c30@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox