From: Paolo Bonzini <pbonzini@redhat.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 2/2] x86: pku: fix parameter passing
Date: Mon, 11 Nov 2019 14:45:52 +0100 [thread overview]
Message-ID: <cc39325b-82ae-e6bd-cd20-74a7b2d30fe3@redhat.com> (raw)
In-Reply-To: <20191025090329.11679-2-chenyi.qiang@intel.com>
On 25/10/19 11:03, Chenyi Qiang wrote:
> Parameter error_code is passed in the function definition while
> the caller miss it. Fix it.
>
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> ---
> x86/pku.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/x86/pku.c b/x86/pku.c
> index 62fb261..1ce73fa 100644
> --- a/x86/pku.c
> +++ b/x86/pku.c
> @@ -38,6 +38,7 @@ asm ("pf_tss: \n\t"
> // no task on x86_64, save/restore caller-save regs
> "push %rax; push %rcx; push %rdx; push %rsi; push %rdi\n"
> "push %r8; push %r9; push %r10; push %r11\n"
> + "mov 9*8(%rsp),%rdi\n"
> #endif
> "call do_pf_tss \n\t"
> #ifdef __x86_64__
>
Currently harmless, but should be fixed. I queued both patches.
Paolo
prev parent reply other threads:[~2019-11-11 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:03 [kvm-unit-tests PATCH 1/2] x86: smap: Use correct reg to pass a parameter Chenyi Qiang
2019-10-25 9:03 ` [kvm-unit-tests PATCH 2/2] x86: pku: fix parameter passing Chenyi Qiang
2019-11-11 13:45 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc39325b-82ae-e6bd-cd20-74a7b2d30fe3@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox