From: Paolo Bonzini <pbonzini@redhat.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>, linux-mm@kvack.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Jan Kara <jack@suse.cz>,
Hugh Dickins <hughd@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com,
linux-ia64@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rdma@vger.kernel.org, kvm@vger.kernel.org,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] mm: remove get_user_pages_locked()
Date: Mon, 31 Oct 2016 12:45:36 +0100 [thread overview]
Message-ID: <cc508436-156e-eb4b-ae01-b44f33c2d692@redhat.com> (raw)
In-Reply-To: <20161031100228.17917-3-lstoakes@gmail.com>
On 31/10/2016 11:02, Lorenzo Stoakes wrote:
> - *
> - * get_user_pages should be phased out in favor of
> - * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing
> - * should use get_user_pages because it cannot pass
> - * FAULT_FLAG_ALLOW_RETRY to handle_mm_fault.
This comment should be preserved in some way. In addition, removing
get_user_pages_locked() makes it harder (compared to a simple "git grep
-w") to identify callers that lack allow-retry functionality). So I'm
not sure about the benefits of these patches.
If all callers were changed, then sure removing the _locked suffix would
be a good idea.
Paolo
next prev parent reply other threads:[~2016-10-31 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 10:02 [PATCH 0/2] mm: remove get_user_pages_locked() Lorenzo Stoakes
2016-10-31 10:02 ` [PATCH 1/2] mm: add locked parameter to get_user_pages() Lorenzo Stoakes
2016-11-07 10:49 ` Jesper Nilsson
2016-11-07 11:00 ` Lorenzo Stoakes
2016-10-31 10:02 ` [PATCH 2/2] mm: remove get_user_pages_locked() Lorenzo Stoakes
2016-10-31 11:45 ` Paolo Bonzini [this message]
2016-10-31 13:48 ` Lorenzo Stoakes
2016-10-31 17:55 ` Paolo Bonzini
2016-10-31 19:28 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc508436-156e-eb4b-ae01-b44f33c2d692@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).