From: Baolu Lu <baolu.lu@linux.intel.com>
To: Yi Liu <yi.l.liu@intel.com>,
joro@8bytes.org, alex.williamson@redhat.com, jgg@nvidia.com,
kevin.tian@intel.com, robin.murphy@arm.com
Cc: baolu.lu@linux.intel.com, cohuck@redhat.com,
eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [RFC 3/8] iommufd: Support attach/replace hwpt per pasid
Date: Wed, 27 Sep 2023 10:49:29 +0800 [thread overview]
Message-ID: <cd258ee3-52ca-f944-7553-6a1cd01c5f7a@linux.intel.com> (raw)
In-Reply-To: <20230926092651.17041-4-yi.l.liu@intel.com>
On 9/26/23 5:26 PM, Yi Liu wrote:
> From: Kevin Tian<kevin.tian@intel.com>
>
> This introduces three APIs for device drivers to manage pasid attach/
> replace/detach.
>
> int iommufd_device_pasid_attach(struct iommufd_device *idev,
> u32 pasid, u32 *pt_id);
> int iommufd_device_pasid_replace(struct iommufd_device *idev,
> u32 pasid, u32 *pt_id);
> void iommufd_device_pasid_detach(struct iommufd_device *idev,
> u32 pasid);
I am a bit puzzled. Do we really need both attach and replace interfaces
to install a hwpt onto a pasid on device? The IOMMUFD already tracks the
connections between hwpt and {device, pasid}, so it could easily call
the right iommu interfaces (attach vs. replace). Perhaps I overlooked
previous discussion on this.
Best regards,
baolu
next prev parent reply other threads:[~2023-09-27 4:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 9:26 [RFC 0/8] iommufd support pasid attach/replace Yi Liu
2023-09-26 9:26 ` [RFC 1/8] iommu: Introduce a replace API for device pasid Yi Liu
2023-09-27 2:04 ` Baolu Lu
2023-09-27 7:45 ` Tian, Kevin
2023-09-26 9:26 ` [RFC 2/8] iommufd: replace attach_fn with a structure Yi Liu
2023-09-27 2:17 ` Baolu Lu
2023-09-27 3:10 ` Tian, Kevin
2023-09-26 9:26 ` [RFC 3/8] iommufd: Support attach/replace hwpt per pasid Yi Liu
2023-09-27 2:49 ` Baolu Lu [this message]
2023-09-27 3:12 ` Tian, Kevin
2023-09-27 15:44 ` Jason Gunthorpe
2023-09-28 1:54 ` Tian, Kevin
2023-09-26 9:26 ` [RFC 4/8] iommufd/selftest: Add set_dev_pasid and remove_dev_pasid in mock iommu Yi Liu
2023-09-26 9:26 ` [RFC 5/8] iommufd/selftest: Add a helper to get test device Yi Liu
2023-09-26 9:26 ` [RFC 6/8] iommufd/selftest: Add test ops to test pasid attach/detach Yi Liu
2023-09-26 9:26 ` [RFC 7/8] iommufd/selftest: Add coverage for iommufd " Yi Liu
2023-09-26 9:26 ` [RFC 8/8] iommu/vt-d: Add set_dev_pasid callback for nested domain Yi Liu
2023-09-27 7:52 ` Tian, Kevin
2023-09-27 7:57 ` Baolu Lu
2023-09-27 8:09 ` Tian, Kevin
2023-10-10 3:33 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd258ee3-52ca-f944-7553-6a1cd01c5f7a@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox