Re: [PATCH 1/2] x86/tdx: Eliminate duplicate code in tdx_clear_page()

[Dave Hansen <dave.hansen@intel.com>]

On 7/3/25 07:39, Adrian Hunter wrote:
> On 03/07/2025 17:14, Dave Hansen wrote:
>> On 7/3/25 04:40, Adrian Hunter wrote:
>>> tdx_clear_page() and reset_tdx_pages() duplicate the TDX page clearing
>>> logic.  Keep the tdx_clear_page() prototype but call reset_tdx_pages() for
>>> the implementation.
>> Why keep the old prototype?
> What prototype would you prefer?

My first reaction is that there should be _one_ function that does the
erratum-related clearing. I'd rather have the KVM sites use the slightly
cumbersome paddr/size arguments than have two functions.

Worst, case, have two functions that have similar names to make it clear
that they are doing the same thing.

It is *NOT* clear that:

	tdx_clear_page()
and
	reset_tdx_pages()

are doing the exact same thing.

I think I'd probably rename reset_tdx_pages() to tdx_reset_paddr() and
then use it in KVM like this:

	tdx_quirk_reset_paddr(page_to_phys(page), PAGE_SIZE);

The alternative would be to retain a function that keeps the 'struct
page' as an argument. Something like:

	tdx_quirk_reset_paddr(unsigned long base, unsigned long size)
and
	tdx_quirk_reset_page(struct page *page)

But the way proposed in this patch is very much a half measure.