From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
Makarand Sonare <makarandsonare@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pshier@google.com, jmattson@google.com,
Ben Gardon <bgardon@google.com>
Subject: Re: [RESEND PATCH ] KVM: VMX: Enable/disable PML when dirty logging gets enabled/disabled
Date: Thu, 11 Feb 2021 09:58:06 +0100 [thread overview]
Message-ID: <ce9b7902-cf3b-3572-dcb9-a0442687dc84@redhat.com> (raw)
In-Reply-To: <YCSRSiSNErkC6+9R@google.com>
On 11/02/21 03:07, Sean Christopherson wrote:
>> Tested:
>> kvm-unit-tests
>> dirty_log_test
>> dirty_log_perf_test
> Eh, I get that we like these for internal tracking, but for upstream there's an
> assumption that you did your due diligence. If there's something noteworthy
> about your testing (or lack thereof), throw it in the cover letter or in the
> part that's not recorded in the final commit.
>
I actually don't mind it and I should do it myself as well. Sure for
large series it's better to put it just once in the cover letter, but
for small submissions such as this one it's not a problem.
Paolo
next prev parent reply other threads:[~2021-02-11 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 21:23 [RESEND PATCH ] KVM: VMX: Enable/disable PML when dirty logging gets enabled/disabled Makarand Sonare
2021-02-11 0:55 ` Sean Christopherson
2021-02-11 9:04 ` Paolo Bonzini
2021-02-11 18:20 ` Sean Christopherson
2021-02-11 2:07 ` Sean Christopherson
2021-02-11 8:58 ` Paolo Bonzini [this message]
2021-02-11 9:04 ` Paolo Bonzini
2021-02-11 15:53 ` Sean Christopherson
2021-02-12 18:12 ` Sean Christopherson
2021-02-12 19:14 ` Makarand Sonare
2021-02-12 21:18 ` Sean Christopherson
2021-02-12 22:13 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce9b7902-cf3b-3572-dcb9-a0442687dc84@redhat.com \
--to=pbonzini@redhat.com \
--cc=bgardon@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=makarandsonare@google.com \
--cc=pshier@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox