From: Thomas Huth <thuth@redhat.com>
To: "Janosch Frank" <frankja@linux.ibm.com>,
kvm@vger.kernel.org, "Nico Böhr" <nrb@linux.ibm.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
linux-s390@vger.kernel.org,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: Re: [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests
Date: Mon, 3 Jun 2024 13:56:02 +0200 [thread overview]
Message-ID: <cebdd4e9-4754-47a6-86c8-283eddd797f8@redhat.com> (raw)
In-Reply-To: <b3444016-91b5-40cc-a4f2-9cb0f5c0cc28@linux.ibm.com>
On 03/06/2024 13.05, Janosch Frank wrote:
> On 6/3/24 09:59, Thomas Huth wrote:
>> Commit ccb37496 ("scripts: allow machine option to be specified in
>> unittests.cfg") added an additonal parameter (the "machine"), but
>> we forgot to add it to the spot that runs the PV test cases, so
>> those are currently broken without this fix.
>>
>> Fixes: ccb37496 ("scripts: allow machine option to be specified in
>> unittests.cfg")
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> LGTM
> Has this issue come up in the Gitlab CI or in your internal CI?
Gitlab CI does not run the PV tests yet - I just noticed it while running
the tests on the s390x machine that I've got access to.
Thomas
next prev parent reply other threads:[~2024-06-03 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 7:59 [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests Thomas Huth
2024-06-03 11:05 ` Janosch Frank
2024-06-03 11:56 ` Thomas Huth [this message]
2024-06-04 4:50 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cebdd4e9-4754-47a6-86c8-283eddd797f8@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox