Re: [kvm-unit-tests PATCH v5 6/6] s390x: add a test for SIE without MSO/MSL

Janosch Frank
2023-08-15T14:27:36Z

On 8/15/23 16:07, Thomas Huth wrote:
> On 15/08/2023 13.30, Janosch Frank wrote:
>> On 8/14/23 16:59, Thomas Huth wrote:
>>> On 01/08/2023 08.51, Nico Boehr wrote:
>>>> Quoting Thomas Huth (2023-07-14 12:52:59)
>>>> [...]
>>>>> Maybe add $(SRCDIR)/s390x to INCLUDE_PATHS in the s390x/Makefile ?
>>>>
>>>> Yeah, that would work, but do we want that? I'd assume that it is a
>>>> concious decision not to have tests depend on one another.
>>>
>>> IMHO this would still be OK ... Janosch, Claudio, what's your opinion on
>>> this?
>>
>> And the headers are then ONLY available via snippets/* ?
>> Pardon my question, not enough cycles, too much work.
>
> No, it's about being able to #include "snippets/c/sie-dat.h" from
> s390x/sie-dat.c, so that guest and host code can share some #defines.
>
> Thomas
>

I'm fine with that.