Re: [kvm-unit-tests PATCH v5 2/6] s390x: add function to set DAT mode for all interrupts

Nico Boehr
2023-07-13T15:36:14Z

Quoting Claudio Imbrenda (2023-07-13 10:24:13)
> On Wed, 12 Jul 2023 13:41:45 +0200
> Nico Boehr <nrb@linux.ibm.com> wrote:
>
> [...]
>
> > +/**
> > + * irq_set_dat_mode - Set the DAT mode of all interrupt handlers, except for
> > + * restart.
> > + * This will update the DAT mode and address space mode of all interrupt new
> > + * PSWs.
> > + *
> > + * Since enabling DAT needs initalized CRs and the restart new PSW is often used
> > + * to initalize CRs, the restart new PSW is never touched to avoid the chicken
> > + * and egg situation.
> > + *
> > + * @dat specifies whether to use DAT or not
> > + * @as specifies the address space mode to use - one of AS_PRIM, AS_ACCR,
>
> please mention here that as will not be set if dat == false

Right, done.