From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Nico Boehr <nrb@linux.ibm.com>,
kvm@vger.kernel.org, frankja@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 0/2] s390x: Add migration test for guest TOD clock
Date: Tue, 11 Oct 2022 18:15:17 +0200 [thread overview]
Message-ID: <cf3fbf75-076f-b5c3-39c8-b490dfe660e1@linux.ibm.com> (raw)
In-Reply-To: <20221011181037.73ae8aa9@p-imbrenda>
Am 11.10.22 um 18:10 schrieb Claudio Imbrenda:
> On Tue, 11 Oct 2022 17:58:29 +0200
> Christian Borntraeger <borntraeger@linux.ibm.com> wrote:
>
>> Am 11.10.22 um 17:14 schrieb Nico Boehr:
>>> v1->v2:
>>> ---
>>> - remove unneeded include
>>> - advance clock by 10 minutes instead of 1 minute (thanks Claudio)
>>> - express get_clock_us() using stck() (thanks Claudio)
>>>
>>> The guest TOD clock should be preserved on migration. Add a test to
>>> verify that.
>>
>> I do not fully agree with this assumption. Its the way it curently is, but we might want to have a configurable or different behaviour in the future.
>>
>> For example if the difference is smaller than time x it could be allowed to move the time forward to get the guest synced to the new host (never go backward though).
>
> the test is actually testing that the clock does not go backwards,
> rather than staying the same
I think this is an must and a perfectly valid test.
prev parent reply other threads:[~2022-10-11 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 15:14 [kvm-unit-tests PATCH v2 0/2] s390x: Add migration test for guest TOD clock Nico Boehr
2022-10-11 15:14 ` [kvm-unit-tests PATCH v2 1/2] lib/s390x: move TOD clock related functions to library Nico Boehr
2022-10-11 15:41 ` Claudio Imbrenda
2022-10-11 15:14 ` [kvm-unit-tests PATCH v2 2/2] s390x: add migration TOD clock test Nico Boehr
2022-10-11 15:49 ` Claudio Imbrenda
2022-10-11 15:58 ` [kvm-unit-tests PATCH v2 0/2] s390x: Add migration test for guest TOD clock Christian Borntraeger
2022-10-11 16:10 ` Claudio Imbrenda
2022-10-11 16:15 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3fbf75-076f-b5c3-39c8-b490dfe660e1@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox