Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c

Eduard - Gabriel Munteanu
2010-03-30T20:15:09Z

On Tue, Mar 30, 2010 at 11:00:10PM +0300, Blue Swirl wrote:
> On 3/30/10, Joerg Roedel <joro@8bytes.org> wrote:
> > On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote:
> > > On 3/30/10, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:
> > > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the
> > > > AMD IOMMU, which could lead to confusion unless we rename the former.
> > >
> > > I was also thinking of renaming the file some time ago. The correct
> > > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a
> > > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had
> > > several IO-UNITs instead. All Sun4m machines had an IOMMU.
> > >
> > > But the qdev name of the device is still "iommu" and we can't change
> > > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside
> > > in amd_iommu.c?
> >
> >
> > Keeping the plain name 'iommu' will likely cause confusion when more
> > iommu implementations are added. It is better to rename it so that the
> > name better describes what the file implements. So this change makes
> > sense for me.
>
> I see. I'm OK then with "sun4m_iommu.c".

Yes, I think it's enough to just change the filename, since multiple
such devices aren't likely to conflict, in any configuration.

Then "sun4m_iommu.c" it is. Will resubmit with the next patchset.

Eduard