Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c

Gerd Hoffmann
2010-03-31T07:27:49Z

On 03/30/10 19:06, Blue Swirl wrote:
> On 3/30/10, Eduard - Gabriel Munteanu<eduard.munteanu@linux360.ro> wrote:
>> hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the
>> AMD IOMMU, which could lead to confusion unless we rename the former.
>
> I was also thinking of renaming the file some time ago. The correct
> name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a
> different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had
> several IO-UNITs instead. All Sun4m machines had an IOMMU.
>
> But the qdev name of the device is still "iommu" and we can't change
> that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside
> in amd_iommu.c?

I'd go for the (filename) rename. The qdev name shouldn't cause
conflicts due to the different targets.

cheers,
Gerd