kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: x86@kernel.org, kvm@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	gleb@redhat.com, Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCHv7 0/8] kvm: eoi optimization support
Date: Thu, 14 Jun 2012 16:52:51 +0300	[thread overview]
Message-ID: <cover.1339681762.git.mst@redhat.com> (raw)

I'm looking at reducing the interrupt overhead for virtualized guests:
some workloads spend a large part of their time processing interrupts.

On kvm, an EOI write from the guest causes an expensive exit to host; we
avoid this using shared memory.

The patches work fine on my boxes. See individual patches
for perf tests. You need to patch qemu to whitelist the kvm feature.
qemu patch was sent separately.

The patches are against Linus's master and apply to kvm.git
cleanly.  The last patch in the series, supplying the host
part, also depends on the ISR optimization patch that I
have for convenience included in the series (patch 2),
I also included a documentation patch (patch 1) - it is
here since it clarifies patch 2.  This revision does not yet address
Thomas's idea of reworking the APIC page handling.  Changes to this
optimization would require reworking this last patch in the series.

The rest of the patchset has not changed significantly since v2.

Thanks,
MST

changes from v6:
	Address Marcelo's comments:
		marcelo's comments for isr optimization: isr_cache -> highest_*
		marcelo's comments for host side eoi: rename isr_cache->highest_*
		kvm eoi msr doc: fix typo pointed out by marcelo
		isr optimization: add comment to address marcelo's request
		kvm: don't make lapic attention check unlikely. at marcelo's request
		eoi host side: remove unlikely annotations

Changes from v5:
	Clear PV EOI when we cancel interrupts.
		Pointed out by Gleb.
	Always set ISR cache when we inject an interrupt.
		Suggested by Ronen Hod.

Changes from v4:
	Turn off PV EOI on each exit. Turn it back on when safe.
		Suggested by Avi.
	Address bug with nested interrupts pointed out by Marcelo.

Changes from v3:
	Address review comments by Marcelo:
		Multiple cosmetic changes eoi -> pv_eoi
		Added multiple comments
Changes from v2:
	Kill guest with GP on an illegal MSR value
	Add documentation

Changes from v1:
	Add host side patch to series
	Remove kvm-specific __test_and_clear_bit, document
	that x86 one does what we want already
	Clear msr on cpu unplug

Michael S. Tsirkin (8):
  kvm: document lapic regs field
  kvm: optimize ISR lookups
  kvm_para: guest side for eoi avoidance
  x86/bitops: note on __test_and_clear_bit atomicity
  kvm: eoi msi documentation
  kvm: only sync when attention bits set
  kvm: rearrange injection cancelling code
  kvm: host side for eoi optimization

 Documentation/virtual/kvm/msr.txt |  32 +++++++
 arch/x86/include/asm/bitops.h     |  13 ++-
 arch/x86/include/asm/kvm_host.h   |  12 +++
 arch/x86/include/asm/kvm_para.h   |   7 ++
 arch/x86/kernel/kvm.c             |  51 +++++++++-
 arch/x86/kvm/cpuid.c              |   1 +
 arch/x86/kvm/lapic.c              | 193 ++++++++++++++++++++++++++++++++++++--
 arch/x86/kvm/lapic.h              |  11 +++
 arch/x86/kvm/trace.h              |  34 +++++++
 arch/x86/kvm/x86.c                |  20 +++-
 10 files changed, 358 insertions(+), 16 deletions(-)

-- 
MST

             reply	other threads:[~2012-06-14 13:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 13:52 Michael S. Tsirkin [this message]
2012-06-14 13:52 ` [PATCHv7 1/8] kvm: document lapic regs field Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 2/8] kvm: optimize ISR lookups Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 3/8] kvm_para: guest side for eoi avoidance Michael S. Tsirkin
2012-06-18 14:17   ` Avi Kivity
2012-06-18 14:50     ` Michael S. Tsirkin
2012-06-18 15:01       ` Avi Kivity
2012-06-18 17:15         ` Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 4/8] x86/bitops: note on __test_and_clear_bit atomicity Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 5/8] kvm: eoi msi documentation Michael S. Tsirkin
2012-06-18 14:20   ` Avi Kivity
2012-06-18 14:56     ` Michael S. Tsirkin
2012-06-18 15:03       ` Avi Kivity
2012-06-18 16:01         ` Michael S. Tsirkin
2012-06-18 15:00     ` Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 6/8] kvm: only sync when attention bits set Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 7/8] kvm: rearrange injection cancelling code Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 8/8] kvm: host side for eoi optimization Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1339681762.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).