From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
KVM list <kvm@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
xen-devel <Xen-devel@lists.xen.org>,
linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 0/3] x86/paravirt: Fix baremetal paravirt MSR ops
Date: Wed, 16 Sep 2015 16:33:11 -0700 [thread overview]
Message-ID: <cover.1442445946.git.luto@kernel.org> (raw)
Setting CONFIG_PARAVIRT=y has an unintended side effect: it silently
turns all rdmsr and wrmsr operations into the safe variants without
any checks that the operations actually succeed.
This is IMO awful: it papers over bugs. In particular, KVM gueests
might be unwittingly depending on this behavior because
CONFIG_KVM_GUEST currently depends on CONFIG_PARAVIRT. I'm not
aware of any such problems, but applying this series would be a good
way to shake them out.
Fix it so that the MSR operations work the same on CONFIG_PARAVIRT=n
and CONFIG_PARAVIRT=y as long as Xen isn't being used. The Xen
maintainers are welcome to make a similar change on top of this.
Since there's plenty of time before the next merge window, I think
we should apply and fix anything that breaks.
Doing this is probably a prerequisite to sanely decoupling
CONFIG_KVM_GUEST and CONFIG_PARAVIRT, which would probably make
Arjan and the rest of the Clear Containers people happy :)
Andy Lutomirski (3):
x86/paravirt: Add _safe to the read_msr and write_msr PV hooks
x86/paravirt: Add paravirt_{read,write}_msr
x86/paravirt: Make "unsafe" MSR accesses unsafe even if PARAVIRT=y
arch/x86/include/asm/paravirt.h | 45 +++++++++++++++++++++--------------
arch/x86/include/asm/paravirt_types.h | 12 +++++++---
arch/x86/kernel/paravirt.c | 6 +++--
arch/x86/xen/enlighten.c | 27 +++++++++++++++++++--
4 files changed, 65 insertions(+), 25 deletions(-)
--
2.4.3
next reply other threads:[~2015-09-16 23:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 23:33 Andy Lutomirski [this message]
2015-09-16 23:33 ` [PATCH 1/3] x86/paravirt: Add _safe to the read_msr and write_msr PV hooks Andy Lutomirski
2015-09-16 23:33 ` [PATCH 2/3] x86/paravirt: Add paravirt_{read,write}_msr Andy Lutomirski
2015-09-16 23:33 ` [PATCH 3/3] x86/paravirt: Make "unsafe" MSR accesses unsafe even if PARAVIRT=y Andy Lutomirski
2015-09-17 7:19 ` [PATCH 0/3] x86/paravirt: Fix baremetal paravirt MSR ops Ingo Molnar
2015-09-17 9:31 ` Borislav Petkov
2015-09-17 11:22 ` H. Peter Anvin
2015-09-17 11:39 ` Paolo Bonzini
2015-09-17 15:27 ` Borislav Petkov
2015-09-17 15:32 ` [Xen-devel] " Andrew Cooper
2015-09-17 15:37 ` Borislav Petkov
2015-09-17 15:23 ` Andy Lutomirski
2015-09-17 15:27 ` Arjan van de Ven
2015-09-17 15:29 ` Paolo Bonzini
2015-09-17 15:31 ` Arjan van de Ven
2015-09-17 15:33 ` Paolo Bonzini
2015-09-17 17:30 ` Ingo Molnar
2015-09-17 18:51 ` Andy Lutomirski
2015-09-17 8:58 ` Peter Zijlstra
2015-09-17 11:40 ` Paolo Bonzini
2015-09-17 12:27 ` Peter Zijlstra
2015-09-17 15:17 ` Andy Lutomirski
2015-09-17 15:17 ` Peter Zijlstra
2015-09-17 15:26 ` Andy Lutomirski
2015-09-17 15:29 ` Paolo Bonzini
2015-09-17 9:10 ` [Xen-devel] " Andrew Cooper
2015-09-17 15:11 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1442445946.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=Xen-devel@lists.xen.org \
--cc=arjan@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).