public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Krister Johansen <kjlx@templeofstupid.com>
To: stable@vger.kernel.org
Cc: Oliver Upton <oliver.upton@linux.dev>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	David Matlack <dmatlack@google.com>,
	kvm@vger.kernel.org
Subject: [PATCH 5.15.y v2 0/2] fix softlockups in stage2_apply_range()
Date: Tue, 5 Mar 2024 16:49:34 -0800	[thread overview]
Message-ID: <cover.1709685364.git.kjlx@templeofstupid.com> (raw)
In-Reply-To: <cover.1709665227.git.kjlx@templeofstupid.com>

Hi Stable Team,
In 5.15, unmapping large kvm vms on arm64 can generate softlockups.  My team has
been hitting this when tearing down VMs > 100Gb in size.

Oliver fixed this with the attached patches.  They've been in mainline since
6.1.

I tested on 5.15.150 with these patches applied. When they're present,
both the dirty_log_perf_test detailed in the second patch, and
kvm_page_table_test no longer generate softlockups when unmapping VMs
with large memory configurations.

Would you please consider these patches for inclusion in an upcoming 5.15
release?

Change in v2:  I ran format-patch without the --from option which incorrectly
generated the first series without leaving Oliver in place as the author.  The
v2 should retain the correct authorship.  Apologies for the mistake.

-K

Oliver Upton (2):
  KVM: arm64: Work out supported block level at compile time
  KVM: arm64: Limit stage2_apply_range() batch size to largest block

 arch/arm64/include/asm/kvm_pgtable.h    | 18 +++++++++++++-----
 arch/arm64/include/asm/stage2_pgtable.h | 20 --------------------
 arch/arm64/kvm/mmu.c                    |  9 ++++++++-
 3 files changed, 21 insertions(+), 26 deletions(-)

-- 
2.25.1


  parent reply	other threads:[~2024-03-06  0:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 19:41 [PATCH 5.15.y 0/2] fix softlockups in stage2_apply_range() Krister Johansen
2024-03-05 19:41 ` [PATCH 5.15.y 1/2] KVM: arm64: Work out supported block level at compile time Krister Johansen
2024-03-05 19:41 ` [PATCH 5.15.y 2/2] KVM: arm64: Limit stage2_apply_range() batch size to largest block Krister Johansen
2024-03-05 19:49 ` [PATCH 5.15.y 0/2] fix softlockups in stage2_apply_range() Oliver Upton
2024-03-06  0:49 ` Krister Johansen [this message]
2024-03-06  0:49   ` [PATCH 5.15.y v2 1/2] KVM: arm64: Work out supported block level at compile time Krister Johansen
2024-03-06  0:49   ` [PATCH 5.15.y v2 2/2] KVM: arm64: Limit stage2_apply_range() batch size to largest block Krister Johansen
2024-03-06 10:08   ` [PATCH 5.15.y v2 0/2] fix softlockups in stage2_apply_range() Marc Zyngier
2024-03-29 12:21     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1709685364.git.kjlx@templeofstupid.com \
    --to=kjlx@templeofstupid.com \
    --cc=alexandru.elisei@arm.com \
    --cc=dmatlack@google.com \
    --cc=james.morse@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox