Re: [PATCH 2/9] x86/virt/tdx: Unbind global metadata read with 'struct tdx_tdmr_sysinfo'

Huang, Kai
2024-06-18T23:29:25Z

> > static int read_sys_metadata_field16(u64 field_id,
> > int offset,
> > - struct tdx_tdmr_sysinfo *ts)
> > + void *stbuf)
> > {
> > - u16 *ts_member = ((void *)ts) + offset;
> > + u16 *st_member = stbuf + offset;
>
> This st_* prefix is completely arbitrary, Just name it "member" since
> this function can be used for any arbitrary member.
>
>

OK fine to me.