From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61AB255E34 for ; Tue, 8 Jul 2025 07:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751958569; cv=none; b=sClakvOkyUYFXRj1HDPCSyQy1omN+eBfIQ+X9km7cguxFo9Tckg8h0Kk3LIhQSgtcXxso4Jr3PgNORCm/kDMwpiO03zUSCdzb6aLzkXgHM1bGClp1spb+qz2BoCk+TnEOyHOk+rO5ZlgINt9TRLezx6VJPsTTnSC3OGLzUfgzEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751958569; c=relaxed/simple; bh=c6JcEJHx34S+DDQ1X9ByoI5T3eS4CDivrbnmLjsLrLc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rf98rXM1WAy0vuUcFyCJwLLMlTmyTJvLAEyBlzpdv2qZ1r6+K5n3jQh0Ej8AfsrMRXYv9juUpQytzsD1El/uhkd/5WK37HB7oiM9iN5tPV91zuprflgdamt65IqObXjCtvxRtDMnDPsFS5RSo38EBVGCavaTuHCMxyHWVaIakc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IlEcKSx4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IlEcKSx4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751958566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ENf0mzNjLnBBq2nYIWPCbEz6bh/GGs1s8F10BFrtKIY=; b=IlEcKSx4jEBqDC2Q685K98bV575b/4JpeZGPqYaIBclEcN2RhVY3OuTioGdJVm/shdVlb6 jkvBd0jWojMVWPUmEEcTQzfSaLZeFUfaR7YRQMfwAfIY/4859jAYheZQacbJorZG4022jH fBmt+QnhYXmwZeazJZ0rdu6BePUXg9A= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-G4-v3lrtP8SgKYf-3nX4WA-1; Tue, 08 Jul 2025 03:09:23 -0400 X-MC-Unique: G4-v3lrtP8SgKYf-3nX4WA-1 X-Mimecast-MFC-AGG-ID: G4-v3lrtP8SgKYf-3nX4WA_1751958561 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 625DF1800366; Tue, 8 Jul 2025 07:09:21 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.44.32.252]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AD9E0195608F; Tue, 8 Jul 2025 07:09:15 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: Willem de Bruijn , Jason Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Michael S. Tsirkin" , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Yuri Benditovich , Akihiko Odaki , Jonathan Corbet , kvm@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH v7 net-next 0/9] virtio: introduce GSO over UDP tunnel Date: Tue, 8 Jul 2025 09:08:56 +0200 Message-ID: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Some virtualized deployments use UDP tunnel pervasively and are impacted negatively by the lack of GSO support for such kind of traffic in the virtual NIC driver. The virtio_net specification recently introduced support for GSO over UDP tunnel, this series updates the virtio implementation to support such a feature. Currently the kernel virtio support limits the feature space to 64, while the virtio specification allows for a larger number of features. Specifically the GSO-over-UDP-tunnel-related virtio features use bits 65-69. The first four patches in this series rework the virtio and vhost feature support to cope with up to 128 bits. The limit is set by a define and could be easily raised in future, as needed. This implementation choice is aimed at keeping the code churn as limited as possible. For the same reason, only the virtio_net driver is reworked to leverage the extended feature space; all other virtio/vhost drivers are unaffected, but could be upgraded to support the extended features space in a later time. The last four patches bring in the actual GSO over UDP tunnel support. As per specification, some additional fields are introduced into the virtio net header to support the new offload. The presence of such fields depends on the negotiated features. New helpers are introduced to convert the UDP-tunneled skb metadata to an extended virtio net header and vice versa. Such helpers are used by the tun and virtio_net driver to cope with the newly supported offloads. Tested with basic stream transfer with all the possible permutations of host kernel/qemu/guest kernel with/without GSO over UDP tunnel support. --- WRT the merge plan, this is also are available in the Git repository at [1]: git@github.com:pabeni/linux-devel.git virtio_udp_tunnel_07_07_2025 The first 5 patches in this series, that is, the virtio features extension bits are also available at [2]: git@github.com:pabeni/linux-devel.git virtio_features_extension_07_07_2025 Ideally the virtio features extension bit should go via the virtio tree and the virtio_net/tun patches via the net-next tree. The latter have a dependency in the first and will cause conflicts if merged via the virtio tree, both when applied and at merge window time - inside Linus tree. To avoid such conflicts and duplicate commits I think the net-next could pull from [1], while the virtio tree could pull from [2]. --- v6 -> v7: - avoid warning in csky build - rebased v6: https://lore.kernel.org/netdev/cover.1750753211.git.pabeni@redhat.com/ v5 -> v6: - fix integer overflow in patch 4/9 v5: https://lore.kernel.org/netdev/cover.1750436464.git.pabeni@redhat.com/ v4 -> v5: - added new patch 1/9 to avoid kdoc issues - encapsulate guest features guessing in new tap helper - cleaned-up SET_FEATURES_ARRAY - a few checkpatch fixes v4: https://lore.kernel.org/netdev/cover.1750176076.git.pabeni@redhat.com/ v3 -> v4: - vnet sockopt cleanup - fixed offset for UDP-tunnel related field - use dev->features instead of flags v3: https://lore.kernel.org/netdev/cover.1749210083.git.pabeni@redhat.com/ v2 -> v3: - uint128_t -> u64[2] - dropped related ifdef - define and use vnet_hdr with tunnel layouts v2: https://lore.kernel.org/netdev/cover.1748614223.git.pabeni@redhat.com/ v1 -> v2: - fix build failures - many comment clarification - changed the vhost_net ioctl API - fixed some hdr <> skb helper bugs v1: https://lore.kernel.org/netdev/cover.1747822866.git.pabeni@redhat.com/ Paolo Abeni (9): scripts/kernel_doc.py: properly handle VIRTIO_DECLARE_FEATURES virtio: introduce extended features virtio_pci_modern: allow configuring extended features vhost-net: allow configuring extended features virtio_net: add supports for extended offloads net: implement virtio helpers to handle UDP GSO tunneling. virtio_net: enable gso over UDP tunnel support. tun: enable gso over UDP tunnel support. vhost/net: enable gso over UDP tunnel support. drivers/net/tun.c | 58 ++++++-- drivers/net/tun_vnet.h | 101 +++++++++++-- drivers/net/virtio_net.c | 110 +++++++++++--- drivers/vhost/net.c | 95 +++++++++--- drivers/vhost/vhost.c | 2 +- drivers/vhost/vhost.h | 4 +- drivers/virtio/virtio.c | 43 +++--- drivers/virtio/virtio_debug.c | 27 ++-- drivers/virtio/virtio_pci_modern.c | 10 +- drivers/virtio/virtio_pci_modern_dev.c | 69 +++++---- include/linux/virtio.h | 9 +- include/linux/virtio_config.h | 43 +++--- include/linux/virtio_features.h | 88 +++++++++++ include/linux/virtio_net.h | 197 ++++++++++++++++++++++++- include/linux/virtio_pci_modern.h | 43 +++++- include/uapi/linux/if_tun.h | 9 ++ include/uapi/linux/vhost.h | 7 + include/uapi/linux/vhost_types.h | 5 + include/uapi/linux/virtio_net.h | 33 +++++ scripts/lib/kdoc/kdoc_parser.py | 1 + 20 files changed, 790 insertions(+), 164 deletions(-) create mode 100644 include/linux/virtio_features.h -- 2.49.0