From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C57234EEEC for ; Sat, 21 Mar 2026 05:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774071108; cv=none; b=ZqxFwC/viePvjNHK2cuU5/Tl4UuTJkroBqScYtzdChztV2BeofvTQMekSmKL0fgRNJ21TU5CeY5RPb0VyiiyebkoJXSnjoYAghydUdPa/Xz0csKwMsXFLITMmO7LZC/Cr9Z1boTD88Yo/+ftTjU897rYK8KIp1p609AlagF1/HM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774071108; c=relaxed/simple; bh=abKMir+lamm2r9MN/XOMbOWIQ8gV1sV9mmmdzJ37hII=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=ug3jIqC/KH5McLCd0fxyXI/F8o87GdsBhDw7Mfe1HMAi/H+IKAiJDM+b/gcR4T+cBUVv05AnaiQpkveifqPnQcsGqjCEQEatNxmYRiCz1XjBXUExUCYDX8GyL07+XbI2fKiSJ4RYi5Rl7wbZpD1oUlPrKZLbMTbjDff27Klrp8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XGH8zaZQ; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XGH8zaZQ" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a871daa98fso10377145ad.1 for ; Fri, 20 Mar 2026 22:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774071107; x=1774675907; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=TSrGnm4uwHURRo/Dbgx7AVRGahiZ5mij0ljFmYODkAo=; b=XGH8zaZQrkG8CxSUC0S/lM89XV+r6xihax+TPodNKQ4/H8OknJNAK4sZeZ4rEELerS nYbTdeslhHS4hfpwzbNeSVNpfumWm1ArfIgqt2w45xgbCuqLzpZAVEdHnHp8dbZRj432 rlc2pkSmjTMLdcZ3IO+B5ENhMzDs5KkjML5DZ5KIJxdmcdm/GzK6mnYS5EM0hKzPoSC8 nsrNANIY+exs/Pq5NgIcNq8M1awh8YlsMVjnA2/VCm0UzHWcnXStKbkOyzZUaRKkVdKU Y1KLL6B7OznEnrfK7cfOQoKRSROOycEfWY20NQQiqBsMuNBNGKZD7xKNXHw3pz/HfWBf mAlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774071107; x=1774675907; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TSrGnm4uwHURRo/Dbgx7AVRGahiZ5mij0ljFmYODkAo=; b=FuUdSoiRspWxQ3QpOYOanwdXim9lv4HMabR4syTMNNSg6qWpGF0LTQU5J9i52Ccobf RJG5BlwVXYWVNe8fO+/uwhtRFzFlUyyfQIR8Vp2BZEoJ0gVdAcxwMve86UXyLK4cVB+O mpr7t1rXU2UTXdL+FRxQ+6A8O1a7vSvAHDTtqS3PH34JsbLNs7InVEYzTPkOnakRRQW6 vOEAhgsbshsczE3FDUwWwngczPW0qTEqOMpXh9R1Bus1otprhqoIZXO4Q1MbqVqrUUY2 CuyFE4nGTT/iSkMzi39eGOmMuP0F5NDf/I1G/MyZ2DzNXUTsah5sQV+3iqf76riypDqX OhsQ== X-Forwarded-Encrypted: i=1; AJvYcCWq5YzVkgRqHO92pJuGkJIkjB8i/xNZobvSgphuCu6BKTiECOQZZ5SJteW531juGVzLtk4=@vger.kernel.org X-Gm-Message-State: AOJu0YwUD6TfBR0usES1kDon8ezNgjTW36hTr/xYS4Rrfrrrwnlj8+f5 P4m+ScqQuKJYNnG5IQIdKHhCp5wayRNawolQBZurzJ2drU7H1okGIkxw X-Gm-Gg: ATEYQzyL6ofGgt/aZ6FoiT+FyjYdAhy1HQczqRIY3mvmpbT7aADUUv5+q4OeCj3KIWY QGCX1STz0Sb6FHqIY3H7bNJvDs5VCnBEsYJm2OQhcPQ8k+fAR8p9YeUb1TShZBfm+1iTswKO0uL z/KwiLvQUMFJF3wGlI68JpX7kmruVmZj4y7pnB5M0A5Otcuree9mnnrFcvzi4IaFrtpcbUM8g2R hVvUJZxR0b8XGbDei5h5ZWpyAD/neYkE33u2rk+UtRUzd7UJVcgyuDeaJiM4OpKp/gRVMHibDyA wBrobLWvAc9jzQFtnz0NkyXtOTyMgTWcEKzZI7iM40WdPFzVftbua+HEN+qAjH1AUhW9QYfGSW8 jZIi30wPA/HqiDG567yfm71Z3esdI/mbyx6JQs1TIvXGs1UfljI3yP8F/G7xX9yjHvurR6Rqndu XVrWlGBejSj72z2kqF9AIecg== X-Received: by 2002:a17:903:191:b0:2ae:8272:deb0 with SMTP id d9443c01a7336-2b0826feb3dmr54931105ad.15.1774071106610; Fri, 20 Mar 2026 22:31:46 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516aa6sm55638395ad.9.2026.03.20.22.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 22:31:45 -0700 (PDT) From: Ritesh Harjani (IBM) To: Baolin Wang , akpm@linux-foundation.org, david@kernel.org Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] mm: change to return bool for pudp_test_and_clear_young() In-Reply-To: <2711ec4bf6c30182004e34027fb31a2e8e24749e.1773890510.git.baolin.wang@linux.alibaba.com> Date: Sat, 21 Mar 2026 11:00:45 +0530 Message-ID: References: <2711ec4bf6c30182004e34027fb31a2e8e24749e.1773890510.git.baolin.wang@linux.alibaba.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > The pudp_test_and_clear_young() is used to clear the young flag, > returning whether the young flag was set for this PUD entry. Change > the return type to bool to make the intention clearer. > > Signed-off-by: Baolin Wang > --- > arch/powerpc/include/asm/book3s/64/pgtable.h | 10 +++++----- > arch/powerpc/mm/book3s64/pgtable.c | 4 ++-- > arch/riscv/include/asm/pgtable.h | 4 ++-- > arch/x86/include/asm/pgtable.h | 4 ++-- > arch/x86/mm/pgtable.c | 6 +++--- > 5 files changed, 14 insertions(+), 14 deletions(-) > LGTM. Please feel free to add: (assuming you will anyway kill the unwanted externs) Reviewed-by: Ritesh Harjani (IBM)