Re: [kvm:kvm-coco-queue-20250129 43/129] arch/x86/kvm/vmx/main.c:176:13: error: 'vt_exit' undeclared; did you mean 'vmx_exit'?

["Huang, Kai" <kai.huang@intel.com>]

On 31/01/2025 11:57 pm, lkp wrote:
> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-coco-queue-20250129
> head:   0bc4f452607db4e7eee4d3056cd6ec98636260bc
> commit: 4b55a8f7c5f508fe1dd0005aecc81bbb5676aaec [43/129] KVM: VMX: Refactor VMX module init/exit functions
> config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250131/202501311811.fRf67aOn-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250131/202501311811.fRf67aOn-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501311811.fRf67aOn-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     In file included from include/linux/kallsyms.h:14,
>                      from include/linux/ftrace.h:13,
>                      from include/linux/kvm_host.h:32,
>                      from arch/x86/kvm/vmx/x86_ops.h:5,
>                      from arch/x86/kvm/vmx/main.c:4:
>     arch/x86/kvm/vmx/main.c: In function '__exittest':
>>> arch/x86/kvm/vmx/main.c:176:13: error: 'vt_exit' undeclared (first use in this function); did you mean 'vmx_exit'?
>       176 | module_exit(vt_exit);

[...]

>     171	static void __vt_exit(void)
>     172	{
>     173		vmx_exit();
>     174		kvm_x86_vendor_exit();
>     175	}
>   > 176	module_exit(vt_exit);
>     177	
> 

The above module_exit(vt_exit) was mistakenly added in the branch 
kvm-coco-queue-20250129, causing this build issue.  There's the second 
module_exit(vt_exit) (the right one) right after this:

+static void __vt_exit(void)
+{
+       vmx_exit();
+       kvm_x86_vendor_exit();
+}
+module_exit(vt_exit);		<--- mistakenly added
+
+static void __exit vt_exit(void)
+{
+       kvm_exit();
+       __vt_exit();
+}
+module_exit(vt_exit);		<--- the right one

The kvm-coco-queue branch doesn't have this issue.