From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74833C05027 for ; Mon, 6 Feb 2023 12:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbjBFMue (ORCPT ); Mon, 6 Feb 2023 07:50:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbjBFMud (ORCPT ); Mon, 6 Feb 2023 07:50:33 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A472D55 for ; Mon, 6 Feb 2023 04:50:32 -0800 (PST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316Cansh024418; Mon, 6 Feb 2023 12:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=upD3/kX31wc4ZUWUKILtzQmhrsGxhsPrJi3DuQw4VY0=; b=BLro4v3c+MUzt8tZRDxc/lm2qeE+cnCdYcSBHE8vx5C2ehLYgMW3/ck+oKnigvkaRxVA IXGaIj16b4REKdtGhiIG2ek0l0ERXKDov+DHcIvHTc93gKFl8yLBjPbVFJiLxRL2uxNT FjdnRT7RitztlnCdIAe+037FcU+tZSBmfUImvUvIGFjbhBbBLTwn2T/e66Bijrhaqy/U f4E6YAGKUgL6ddm9zsSQK6Qx4dDL9wfXFp6RnA9jbZL69AmDFdYMzDMzx1FV8hIlRJxC up5R9G1YluREAhkgFCTwb1bdgIeb4k4ckpOErB8x6I7/uPvnLN2kumGzVX0gHetrnDfj UQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nk1gkgp49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 12:50:17 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 316CljNl029585; Mon, 6 Feb 2023 12:50:17 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nk1gkgp2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 12:50:16 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3164i6bm018248; Mon, 6 Feb 2023 12:50:13 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma03fra.de.ibm.com (PPS) with ESMTPS id 3nhf06hpuh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 12:50:13 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 316Co9GG23921048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Feb 2023 12:50:09 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAA3620049; Mon, 6 Feb 2023 12:50:09 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FE332004B; Mon, 6 Feb 2023 12:50:08 +0000 (GMT) Received: from [9.171.30.242] (unknown [9.171.30.242]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Feb 2023 12:50:08 +0000 (GMT) Message-ID: Date: Mon, 6 Feb 2023 13:50:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v15 05/11] s390x/cpu topology: resetting the Topology-Change-Report Content-Language: en-US To: Thomas Huth , qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, pasic@linux.ibm.com, richard.henderson@linaro.org, david@redhat.com, cohuck@redhat.com, mst@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, eblake@redhat.com, armbru@redhat.com, seiden@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, frankja@linux.ibm.com, berrange@redhat.com, clg@kaod.org References: <20230201132051.126868-1-pmorel@linux.ibm.com> <20230201132051.126868-6-pmorel@linux.ibm.com> <88c4686a-985c-9465-d4dd-6cd5b2faa026@redhat.com> From: Pierre Morel In-Reply-To: <88c4686a-985c-9465-d4dd-6cd5b2faa026@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: DmDOlqzL2WKkTCRfLabRoHrpYXrgWcVw X-Proofpoint-GUID: F28BO4Q9XXiVxTx_GYVlTHJ8FSA5Sx6O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_06,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060102 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2/6/23 12:05, Thomas Huth wrote: > On 01/02/2023 14.20, Pierre Morel wrote: >> During a subsystem reset the Topology-Change-Report is cleared >> by the machine. >> Let's ask KVM to clear the Modified Topology Change Report (MTCR) >> bit of the SCA in the case of a subsystem reset. >> >> Signed-off-by: Pierre Morel >> --- > ... >> diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c >> index a80a1ebf22..cf63f3dd01 100644 >> --- a/hw/s390x/cpu-topology.c >> +++ b/hw/s390x/cpu-topology.c >> @@ -85,6 +85,18 @@ static void s390_topology_init(MachineState *ms) >>       QTAILQ_INSERT_HEAD(&s390_topology.list, entry, next); >>   } >> +/** >> + * s390_topology_reset: >> + * >> + * Generic reset for CPU topology, calls s390_topology_reset() >> + * s390_topology_reset() to reset the kernel Modified Topology > > Duplicated s390_topology_reset() in the comment. right, thx. > >> + * change record. >> + */ >> +void s390_topology_reset(void) >> +{ >> +    s390_cpu_topology_reset(); >> +} > > With the nit fixed: > Reviewed-by: Thomas Huth > Thanks! Regards, Pierre -- Pierre Morel IBM Lab Boeblingen