Re: [RFC Part1 PATCH 05/13] X86/sev-es: move few helper functions in common file

Borislav Petkov
2021-04-02T19:27:29Z

On Wed, Mar 24, 2021 at 11:44:16AM -0500, Brijesh Singh wrote:
> The sev_es_terminate() and sev_es_{wr,rd}_ghcb_msr() helper functions
> in a common file so that it can be used by both the SEV-ES and SEV-SNP.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: x86@kernel.org
> Cc: kvm@vger.kernel.org
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
> arch/x86/boot/compressed/sev-common.c | 32 +++++++++++++++++++++++++++
> arch/x86/boot/compressed/sev-es.c | 22 ++----------------
> arch/x86/kernel/sev-common-shared.c | 31 ++++++++++++++++++++++++++
> arch/x86/kernel/sev-es-shared.c | 21 +++---------------
> 4 files changed, 68 insertions(+), 38 deletions(-)
> create mode 100644 arch/x86/boot/compressed/sev-common.c
> create mode 100644 arch/x86/kernel/sev-common-shared.c

Yeah, once you merge it all into sev.c and sev-shared.c, that patch is
not needed anymore.

Thx.

--
Regards/Gruss,
Boris.