From: Thomas Huth <thuth@redhat.com>
To: Nico Boehr <nrb@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU
Date: Tue, 12 Apr 2022 11:33:48 +0200 [thread overview]
Message-ID: <d458e729-1497-b3d7-16fc-eac3e6c54945@redhat.com> (raw)
In-Reply-To: <20220412092941.20742-1-nrb@linux.ibm.com>
On 12/04/2022 11.29, Nico Boehr wrote:
> When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix
> this by pushing the prefix before the QEMU check.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> s390x/epsw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/epsw.c b/s390x/epsw.c
> index 5b73f4b3db6c..d8090d95a486 100644
> --- a/s390x/epsw.c
> +++ b/s390x/epsw.c
> @@ -97,13 +97,13 @@ static void test_epsw(void)
>
> int main(int argc, char **argv)
> {
> + report_prefix_push("epsw");
> +
> if (!host_is_kvm() && !host_is_tcg()) {
> report_skip("Not running under QEMU");
> goto done;
> }
>
> - report_prefix_push("epsw");
> -
> test_epsw();
>
> done:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-04-12 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:29 [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Nico Boehr
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
2022-04-12 9:34 ` Thomas Huth
2022-04-12 11:40 ` [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib " Nico Boehr
2022-04-12 15:35 ` Janosch Frank
2022-04-12 9:33 ` Thomas Huth [this message]
2022-04-12 15:36 ` [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d458e729-1497-b3d7-16fc-eac3e6c54945@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox