From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC82C0015E for ; Wed, 9 Aug 2023 19:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbjHITXz (ORCPT ); Wed, 9 Aug 2023 15:23:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbjHITXk (ORCPT ); Wed, 9 Aug 2023 15:23:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B5AD4201; Wed, 9 Aug 2023 12:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691608641; x=1723144641; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=JIrvQbWkCGHaD1FbqNpWcpoCsdM1hU8OGLnCu18TVvM=; b=QRCQTVHVS7vzeUTk5FMP/GK4Q9WgrRpDSToA/b0nNvCcM1eKzv/99glU mmeXCuitpkNSXb2rfa/SkkcuymukXBdJKFupkQwDyaWRPrqsI/BY1iMvM VdMYbpXUn+/cZDg9ETAzsgr+feehrW5fKP7ZxpziGfnRAiAunjrnlukAr 6G5zfGwwG0F1YSeUvlYpwsqtIZyTc/krsbGLzG24rXSb6Yt1bWOFv5WRz saRlrgE+uIFn87jkK1KOn8yWm48+FQspqRqh08FOo95Mram9kKgEFStRZ Ue7YMCNvmXPtbxLMbo5TzlufaG5tPQ9N+6hmwFudp2m18nzjr84RGUX+X Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="402170570" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="402170570" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 12:16:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="708843770" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="708843770" Received: from sakkired-mobl1.amr.corp.intel.com (HELO [10.212.9.77]) ([10.212.9.77]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 12:16:18 -0700 Message-ID: Date: Wed, 9 Aug 2023 12:16:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Sean Christopherson , Paolo Bonzini , Josh Poimboeuf Cc: "H. Peter Anvin" , Peter Zijlstra , Maxim Levitsky , Michal Luczaj , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20230809130530.1913368-1-arnd@kernel.org> <20230809130530.1913368-2-arnd@kernel.org> From: Daniel Sneddon Subject: Re: [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 8/9/23 11:26, Arnd Bergmann wrote: > On Wed, Aug 9, 2023, at 18:54, Daniel Sneddon wrote: >> HI Arnd, >> >> On 8/9/23 06:05, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> The declaration got placed in the .c file of the caller, but that >>> causes a warning for the definition: >>> >>> arch/x86/kernel/cpu/bugs.c:682:6: error: no previous prototype for 'gds_ucode_mitigated' [-Werror=missing-prototypes] >> >> When I build with gcc 9.4 and the x86_64_defconfig I don't see this warning even >> without this patch. I'm curious why you're seeing it and I'm not. Any ideas? > > The warning is currently disabled by default, unless you build with > 'make W=1'. I'm in the process of getting my last patches out to > change this so the warning is enabled by default though, so I was > phrasing this based on the future behavior. Sorry if this was confusing. > > Arnd That explains why I wasn't seeing it. Feel free to add: Tested-by: Daniel Sneddon Thanks, Dan