Re: [PATCH 2/2] Allow building vhost-user in BSD

Paolo Bonzini
2022-03-02T17:10:30Z

On 3/2/22 12:36, Sergio Lopez wrote:
> With the possibility of using pipefd as a replacement on operating
> systems that doesn't support eventfd, vhost-user can also work on BSD
> systems.
>
> This change allows enabling vhost-user on BSD platforms too and
> makes libvhost_user (which still depends on eventfd) a linux-only
> feature.
>
> Signed-off-by: Sergio Lopez <slp@redhat.com>

I would just check for !windows.

Paolo

> ---
> configure | 5 +++--
> meson.build | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index c56ed53ee3..93aa22e345 100755
> --- a/configure
> +++ b/configure
> @@ -1659,8 +1659,9 @@ fi
> # vhost interdependencies and host support
>
> # vhost backends
> -if test "$vhost_user" = "yes" && test "$linux" != "yes"; then
> - error_exit "vhost-user is only available on Linux"
> +if test "$vhost_user" = "yes" && \
> + test "$linux" != "yes" && test "$bsd" != "yes" ; then
> + error_exit "vhost-user is only available on Linux and BSD"
> fi
> test "$vhost_vdpa" = "" && vhost_vdpa=$linux
> if test "$vhost_vdpa" = "yes" && test "$linux" != "yes"; then
> diff --git a/meson.build b/meson.build
> index 8df40bfac4..f2bc439c30 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2701,7 +2701,7 @@ if have_system or have_user
> endif
>
> vhost_user = not_found
> -if 'CONFIG_VHOST_USER' in config_host
> +if targetos == 'linux' and 'CONFIG_VHOST_USER' in config_host
> libvhost_user = subproject('libvhost-user')
> vhost_user = libvhost_user.get_variable('vhost_user_dep')
> endif