From: Binbin Wu <binbin.wu@linux.intel.com>
To: "Huang, Kai" <kai.huang@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, seanjc@google.com, isaku.yamahata@intel.com,
rick.p.edgecombe@intel.com, michael.roth@amd.com
Subject: Re: [PATCH v2 2/2] KVM: x86: Use is_kvm_hc_exit_enabled() instead of opencode
Date: Mon, 19 Aug 2024 18:07:42 +0800 [thread overview]
Message-ID: <d7995584-f844-4a05-99d7-a3a85ef11516@linux.intel.com> (raw)
In-Reply-To: <0b27494f-7ce0-4ca7-8238-cb95999b3142@intel.com>
On 8/14/2024 7:18 AM, Huang, Kai wrote:
>
>
> On 13/08/2024 5:12 pm, Binbin Wu wrote:
>> Use is_kvm_hc_exit_enabled() instead of opencode.
>>
>> No functional change intended.
>
> It would be helpful to mention currently hypercall_exit_enabled can
> only have KVM_HC_MAP_GPA_RANGE bit set (so that there will be no
> functional change).
I think it's not needed, because is_kvm_hc_exit_enabled() takes the input.
It just replaces the opencode with a helper API.
Maybe your comment was for the patch 1?
>
>>
>> Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
>
> Reviewed-by: Kai Huang <kai.huang@intel.com>
>
Thanks for your review.
next prev parent reply other threads:[~2024-08-19 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 5:12 [PATCH v2 0/2] KVM: x86: Check hypercall's exit to userspace generically Binbin Wu
2024-08-13 5:12 ` [PATCH v2 1/2] " Binbin Wu
2024-08-13 5:56 ` Yuan Yao
2024-08-13 6:14 ` Yuan Yao
2024-08-13 17:50 ` Isaku Yamahata
2024-08-13 23:11 ` Huang, Kai
2024-08-14 0:52 ` Isaku Yamahata
2024-08-14 1:27 ` Binbin Wu
2024-08-14 1:31 ` Sean Christopherson
2024-08-14 2:36 ` Huang, Kai
2024-08-14 4:59 ` Binbin Wu
2024-08-13 23:16 ` Huang, Kai
2024-08-14 0:53 ` Isaku Yamahata
2024-08-14 1:08 ` Binbin Wu
2024-08-13 5:12 ` [PATCH v2 2/2] KVM: x86: Use is_kvm_hc_exit_enabled() instead of opencode Binbin Wu
2024-08-13 17:51 ` Isaku Yamahata
2024-08-13 23:18 ` Huang, Kai
2024-08-19 10:07 ` Binbin Wu [this message]
2024-08-19 22:24 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7995584-f844-4a05-99d7-a3a85ef11516@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox