Re: [PATCH 02/11] driver core: Set DMA ownership during driver bind/unbind

Christoph Hellwig
2021-11-15T13:21:08Z

On Mon, Nov 15, 2021 at 07:59:10AM +0100, Greg Kroah-Hartman wrote:
> This feels wrong to be doing it in the driver core, why doesn't the bus
> that cares about this handle it instead?
>
> You just caused all drivers in the kernel today to set and release this
> ownership, as none set this flag. Shouldn't it be the other way around?
>
> And again, why not in the bus that cares?
>
> You only have problems with 1 driver out of thousands, this feels wrong
> to abuse the driver core this way for just that one.

This isn't really a bus thingy, but related to the IOMMU subsystem.
That being said as pointed out in my previous reply I'd expect this
to go along with other IOMMU setup.