From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EC0C43613 for ; Thu, 20 Jun 2019 09:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C5EF2084A for ; Thu, 20 Jun 2019 09:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731262AbfFTJAA (ORCPT ); Thu, 20 Jun 2019 05:00:00 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37313 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfFTJAA (ORCPT ); Thu, 20 Jun 2019 05:00:00 -0400 Received: by mail-wm1-f67.google.com with SMTP id f17so2296871wme.2 for ; Thu, 20 Jun 2019 01:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vddaDNU08aTNsQcXmYBUi4ms30pth+CnMAqKshaYelA=; b=Ay5SOpguN5MpebtKPjGZDsH3wGfcoHMHh6EUoUGdWxAxSSiOaXgdaLrDdgS5AdNL+t 0HsnU300ikA2hQafdyIetJx1Gc5oofqAMBJgbgFi+XurkjvMmb6FVgsLDITkskx+Ybvw ju4pc1AKdb7E+vYI7oMgITiv3feYjIVbVW3EqpuSUQpIf1yrBwMMfx1GiyhEtg64x2Fy w/EaepWMLBQcCt9MV4vVFLSN2q7MFNWbj3MOPgi3RuDeIjvR7f1W7jMYbRGQheniFMtD PEku1k/dTZYu5wzIU025hDLciTnT2pS43NTkE3NUeYAhjcxrYuJmSLng2v/9gqsVyuE8 LYRg== X-Gm-Message-State: APjAAAVM4Fgn4wk7s1XwREyIRlTiBebvodkyLqt6hof6B9V74egctrJO rL4vvukwWJNJNG1fozhgMqG5Mg== X-Google-Smtp-Source: APXvYqzbNKZHwFaDBe6SMO2bSr6qfYnU7CP2hxFaCBO+4IgEmShvwUEIym/VhGTbzqTkuDXSF9OE5g== X-Received: by 2002:a1c:f20f:: with SMTP id s15mr1823342wmc.33.1561021197712; Thu, 20 Jun 2019 01:59:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:7822:aa18:a9d8:39ab? ([2001:b07:6468:f312:7822:aa18:a9d8:39ab]) by smtp.gmail.com with ESMTPSA id a2sm4789699wmj.9.2019.06.20.01.59.56 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jun 2019 01:59:57 -0700 (PDT) Subject: Re: [PATCH] KVM: vmx: Fix the broken usage of vmx_xsaves_supported To: Xiaoyao Li , Wanpeng Li , Tao Xu Cc: Radim Krcmar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , kvm , LKML References: <20190620050301.1149-1-tao3.xu@intel.com> <2032f811-b583-eca1-3ece-d1e95738ff64@linux.intel.com> From: Paolo Bonzini Message-ID: Date: Thu, 20 Jun 2019 10:59:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2032f811-b583-eca1-3ece-d1e95738ff64@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 20/06/19 10:55, Xiaoyao Li wrote: > >> However I may be wrong because I didn't review the code very closely: >> the old code is obvious and so there is no point in changing it. > > you mean this part about XSS_EXIT_BITMAP? how about the other part in > vmx_set/get_msr() in this patch? Yes, only the XSS_EXIT_BITMAP part. The other is a bugfix, I didn't understand Wanpeng's objection very well. Paolo