public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Dustin Kirkland <kirkland@canonical.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] qemu-kvm: fix typo in configure
Date: Wed, 1 Jul 2009 16:07:30 -0700	[thread overview]
Message-ID: <d9c105ea0907011607o7b106120u3f4e03a386d2fcfa@mail.gmail.com> (raw)
In-Reply-To: <20090701112720.GA16678@redhat.com>

On Wed, Jul 1, 2009 at 4:27 AM, Michael S. Tsirkin<mst@redhat.com> wrote:
> Kill extra \). Also escape ! for clarity and bourne shell
> compatibility.

Agreed.  Looks like this one was introduced during the last merge from
qemu.  It bit me too.

:-Dustin

> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> This patch fixes configure on next for me
>
>  configure |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index f76f511..b62e3d7 100755
> --- a/configure
> +++ b/configure
> @@ -2141,10 +2141,10 @@ configure_kvm() {
>  }
>
>  # Make sure the target and host cpus are compatible
> -if test ! \( "$target_cpu" = "$cpu" -o \
> +if test \! \( "$target_cpu" = "$cpu" -o \
>   \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \
> -  \( "$target_cpu" = "x86_64" -a "$cpu" = "i386"   \) -o \
> -  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) \) -o \
> +  \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \
> +  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) -o \
>   \( "$target_cpu" = "ia64"   -a "$cpu" = "ia64" \) \) ; then
>   target_kvm="no"
>  fi

  reply	other threads:[~2009-07-01 23:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 11:27 [PATCH] qemu-kvm: fix typo in configure Michael S. Tsirkin
2009-07-01 23:07 ` Dustin Kirkland [this message]
2009-07-02 11:22 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9c105ea0907011607o7b106120u3f4e03a386d2fcfa@mail.gmail.com \
    --to=kirkland@canonical.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox