From: "Clément Léger" <cleger@rivosinc.com>
To: Alexandre Ghiti <alexghiti@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] riscv: Fix typo EXRACT -> EXTRACT
Date: Tue, 22 Apr 2025 11:04:53 +0200 [thread overview]
Message-ID: <db59c652-c4ea-4ed9-abf3-75886924057a@rivosinc.com> (raw)
In-Reply-To: <20250422082545.450453-2-alexghiti@rivosinc.com>
On 22/04/2025 10:25, Alexandre Ghiti wrote:
> Simply fix a typo.
>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> ---
> arch/riscv/include/asm/insn.h | 2 +-
> arch/riscv/kernel/vector.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/include/asm/insn.h b/arch/riscv/include/asm/insn.h
> index 09fde95a5e8f..2a589a58b291 100644
> --- a/arch/riscv/include/asm/insn.h
> +++ b/arch/riscv/include/asm/insn.h
> @@ -352,7 +352,7 @@ static __always_inline bool riscv_insn_is_c_jalr(u32 code)
> ({typeof(x) x_ = (x); RV_X(x_, RVFDQ_FL_FS_WIDTH_OFF, \
> RVFDQ_FL_FS_WIDTH_MASK); })
>
> -#define RVV_EXRACT_VL_VS_WIDTH(x) RVFDQ_EXTRACT_FL_FS_WIDTH(x)
> +#define RVV_EXTRACT_VL_VS_WIDTH(x) RVFDQ_EXTRACT_FL_FS_WIDTH(x)
>
> /*
> * Get the immediate from a J-type instruction.
> diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c
> index 184f780c932d..901e67adf576 100644
> --- a/arch/riscv/kernel/vector.c
> +++ b/arch/riscv/kernel/vector.c
> @@ -93,7 +93,7 @@ bool insn_is_vector(u32 insn_buf)
> return true;
> case RVV_OPCODE_VL:
> case RVV_OPCODE_VS:
> - width = RVV_EXRACT_VL_VS_WIDTH(insn_buf);
> + width = RVV_EXTRACT_VL_VS_WIDTH(insn_buf);
> if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 ||
> width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64)
> return true;
Hi Alex,
Looks good to me,
Reviewed-By: Clément Léger <cleger@rivosinc.com>
Thanks,
Clément
next prev parent reply other threads:[~2025-04-22 9:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 8:25 [PATCH 0/3] Move duplicated instructions macros into asm/insn.h Alexandre Ghiti
2025-04-22 8:25 ` [PATCH 1/3] riscv: Fix typo EXRACT -> EXTRACT Alexandre Ghiti
2025-04-22 9:04 ` Clément Léger [this message]
2025-04-22 10:20 ` Philippe Mathieu-Daudé
2025-04-24 10:35 ` Andrew Jones
2025-04-22 8:25 ` [PATCH 2/3] riscv: Strengthen duplicate and inconsistent definition of RV_X() Alexandre Ghiti
2025-04-22 9:14 ` Clément Léger
2025-04-24 8:45 ` Andrew Jones
2025-04-25 7:26 ` Andrew Jones
2025-04-22 8:25 ` [PATCH 3/3] riscv: Move all duplicate insn parsing macros into asm/insn.h Alexandre Ghiti
2025-04-22 9:36 ` Clément Léger
2025-05-06 8:05 ` Alexandre Ghiti
2025-04-24 10:35 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db59c652-c4ea-4ed9-abf3-75886924057a@rivosinc.com \
--to=cleger@rivosinc.com \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox