From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: mimu@linux.vnet.ibm.com, KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Janosch Frank <frankja@linux.vnet.ibm.com>
Subject: Re: [PATCH 05/12] s390/css: expose the AIV facility
Date: Thu, 18 Jan 2018 13:02:45 +0100 [thread overview]
Message-ID: <dbfae6e1-ceda-880c-3908-b03193c7d714@linux.vnet.ibm.com> (raw)
In-Reply-To: <29f77b94-a5e1-178d-2364-9dcf77dc9096@redhat.com>
On 17.01.18 16:19, David Hildenbrand wrote:
> On 16.01.2018 21:02, Christian Borntraeger wrote:
>> From: Michael Mueller <mimu@linux.vnet.ibm.com>
>>
>> The patch exposes the Adapter Interruption Virtualization facility (AIV)
>> of the general channel subsystem characteristics.
>>
>> Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
>> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> arch/s390/include/asm/css_chars.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h
>> index a478eb61aaf7..fb56fa3283a2 100644
>> --- a/arch/s390/include/asm/css_chars.h
>> +++ b/arch/s390/include/asm/css_chars.h
>> @@ -20,7 +20,9 @@ struct css_general_char {
>> u32 aif_tdd : 1; /* bit 56 */
>> u32 : 1;
>> u32 qebsm : 1; /* bit 58 */
>> - u32 : 8;
>> + u32 : 2;
>> + u32 aiv : 1; /* bit 61 */
>> + u32 : 5;
>> u32 aif_osa : 1; /* bit 67 */
>> u32 : 12;
>> u32 eadm_rf : 1; /* bit 80 */
>>
> "Expose" sounds like actually forwarding something / enabling a bit.
Expose here basically means to make sth. visible what was already available.
> Wonder if this can be squashed with another patch?
>
> Or rename to something like "define" ...
I don't plan to change anything.
>
Thanks,
Michael
next prev parent reply other threads:[~2018-01-18 12:02 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 20:02 [PATCH 00/12] KVM: s390: exitless interrupt support for KVM Christian Borntraeger
2018-01-16 20:02 ` [PATCH 01/12] KVM: s390: reverse bit ordering of irqs in pending mask Christian Borntraeger
2018-01-16 20:18 ` David Hildenbrand
2018-01-17 10:12 ` Christian Borntraeger
2018-01-18 16:50 ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 02/12] KVM: s390: define GISA format-0 data structure Christian Borntraeger
2018-01-16 20:25 ` David Hildenbrand
2018-01-17 7:57 ` Heiko Carstens
2018-01-18 15:49 ` Michael Mueller
2018-01-18 20:47 ` David Hildenbrand
2018-01-19 10:12 ` Heiko Carstens
2018-01-19 10:17 ` David Hildenbrand
2018-01-19 10:20 ` Heiko Carstens
2018-01-19 10:29 ` Cornelia Huck
2018-01-19 11:28 ` David Hildenbrand
2018-01-16 20:02 ` [PATCH 03/12] s390/bitops: add test_and_clear_bit_inv() Christian Borntraeger
2018-01-16 20:13 ` David Hildenbrand
2018-01-18 16:54 ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 04/12] KVM: s390: implement GISA IPM related primitives Christian Borntraeger
2018-01-17 14:35 ` David Hildenbrand
2018-01-18 14:29 ` Michael Mueller
2018-01-18 14:33 ` David Hildenbrand
2018-01-18 15:58 ` Michael Mueller
2018-01-18 20:45 ` David Hildenbrand
2018-01-19 10:11 ` Heiko Carstens
2018-01-19 10:16 ` David Hildenbrand
2018-01-19 10:17 ` Christian Borntraeger
2018-01-16 20:02 ` [PATCH 05/12] s390/css: expose the AIV facility Christian Borntraeger
2018-01-17 15:19 ` David Hildenbrand
2018-01-18 12:02 ` Michael Mueller [this message]
2018-01-18 17:54 ` Cornelia Huck
2018-01-25 11:42 ` Christian Borntraeger
2018-01-25 12:00 ` Cornelia Huck
2018-01-25 12:04 ` Christian Borntraeger
2018-01-25 15:13 ` Heiko Carstens
2018-01-16 20:02 ` [PATCH 06/12] KVM: s390: exploit GISA and AIV for emulated interrupts Christian Borntraeger
2018-01-17 8:14 ` Heiko Carstens
2018-01-18 18:10 ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 07/12] KVM: s390: abstract adapter interruption word generation from ISC Christian Borntraeger
2018-01-18 18:11 ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 08/12] KVM: s390: add GISA interrupts to FLIC ioctl interface Christian Borntraeger
2018-01-16 20:02 ` [PATCH 09/12] KVM: s390: make kvm_s390_get_io_int() aware of GISA Christian Borntraeger
2018-01-16 20:02 ` [PATCH 10/12] KVM: s390: activate GISA for emulated interrupts Christian Borntraeger
2018-01-16 20:02 ` [PATCH 11/12] s390/sclp: expose the GISA format facility Christian Borntraeger
2018-01-16 20:13 ` David Hildenbrand
2018-01-16 20:02 ` [PATCH 12/12] KVM: s390: introduce the format-1 GISA Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfae6e1-ceda-880c-3908-b03193c7d714@linux.vnet.ibm.com \
--to=mimu@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).