From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QFXp1wcW" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FB211B5; Tue, 5 Dec 2023 22:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701845285; x=1733381285; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=31X1TWrsJxin+f+eEFIJ23ndoGZuq9yKYHwAu/cTynM=; b=QFXp1wcWYYCPxISuORclhkhCIQ2CwSGqLnuab7fEa8sftyYI/IIgm5Dn A22BN736/SNM6VnbT5hmS8gVy8G7WDQ14KssSDM7oXu61Cwp+ZrFUrxii GtxRqKRPIisODGvUxL0ip2GGdYTfXOzEyRBdlwGabgHy65m8DnAbXSLqG NrUm7t7ppKVSqLKztH6l0j7Rhb1xv0s4hfG2w2/d3C502blzWvyWLuwff FXpXdRMGE2G3D5t05EbPBfsDxEsSKKUOVZQvEmitHb0At/ptdXe+MOqFZ O17wWLdHzwYIySTcp7tpnqYoVvyle5Qk6cDA0OBE/hEh/hcg7DnWO9uL/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="458338509" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="458338509" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 22:48:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="774895857" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="774895857" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.238.10.126]) ([10.238.10.126]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 22:48:01 -0800 Message-ID: Date: Wed, 6 Dec 2023 14:47:58 +0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 013/116] KVM: TDX: Add helper functions to print TDX SEAMCALL error To: isaku.yamahata@intel.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com References: From: Binbin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/7/2023 10:55 PM, isaku.yamahata@intel.com wrote: > From: Isaku Yamahata > > Add helper functions to print out errors from the TDX module in a uniform > manner. Reviewed-by: Binbin Wu > > Signed-off-by: Isaku Yamahata > --- > arch/x86/kvm/Makefile | 2 +- > arch/x86/kvm/vmx/tdx_error.c | 20 ++++++++++++++++++++ > arch/x86/kvm/vmx/tdx_ops.h | 5 +++++ > 3 files changed, 26 insertions(+), 1 deletion(-) > create mode 100644 arch/x86/kvm/vmx/tdx_error.c > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 4b01ab842ab7..e3354b784e10 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -25,7 +25,7 @@ kvm-$(CONFIG_KVM_SMM) += smm.o > kvm-intel-y += vmx/vmx.o vmx/vmenter.o vmx/pmu_intel.o vmx/vmcs12.o \ > vmx/hyperv.o vmx/nested.o vmx/posted_intr.o vmx/main.o > kvm-intel-$(CONFIG_X86_SGX_KVM) += vmx/sgx.o > -kvm-intel-$(CONFIG_INTEL_TDX_HOST) += vmx/tdx.o > +kvm-intel-$(CONFIG_INTEL_TDX_HOST) += vmx/tdx.o vmx/tdx_error.o > > kvm-amd-y += svm/svm.o svm/vmenter.o svm/pmu.o svm/nested.o svm/avic.o \ > svm/sev.o svm/hyperv.o > diff --git a/arch/x86/kvm/vmx/tdx_error.c b/arch/x86/kvm/vmx/tdx_error.c > new file mode 100644 > index 000000000000..d083c79a2331 > --- /dev/null > +++ b/arch/x86/kvm/vmx/tdx_error.c > @@ -0,0 +1,20 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* functions to record TDX SEAMCALL error */ > + > +#include > +#include > + > +#include "tdx_ops.h" > + > +void pr_tdx_error(u64 op, u64 error_code, const struct tdx_module_args *out) > +{ > + if (!out) { > + pr_err_ratelimited("SEAMCALL[%lld] failed: 0x%llx\n", > + op, error_code); > + return; > + } > + > +#define MSG "SEAMCALL[%lld] failed: 0x%llx RCX 0x%llx RDX 0x%llx R8 0x%llx R9 0x%llx R10 0x%llx R11 0x%llx\n" > + pr_err_ratelimited(MSG, op, error_code, out->rcx, out->rdx, out->r8, > + out->r9, out->r10, out->r11); > +} > diff --git a/arch/x86/kvm/vmx/tdx_ops.h b/arch/x86/kvm/vmx/tdx_ops.h > index a55977626ae3..c9f74b2400a7 100644 > --- a/arch/x86/kvm/vmx/tdx_ops.h > +++ b/arch/x86/kvm/vmx/tdx_ops.h > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #include "tdx_errno.h" > #include "tdx_arch.h" > @@ -57,6 +58,10 @@ static inline u64 tdx_seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9, > return ret; > } > > +#ifdef CONFIG_INTEL_TDX_HOST > +void pr_tdx_error(u64 op, u64 error_code, const struct tdx_module_args *out); > +#endif > + > static inline u64 tdh_mng_addcx(hpa_t tdr, hpa_t addr) > { > clflush_cache_range(__va(addr), PAGE_SIZE);