From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [Part1 PATCH v4 02/17] x86/mm: Add Secure Encrypted
 Virtualization (SEV) support
Date: Tue, 26 Sep 2017 14:06:08 -0500
Message-ID: <dcafa981-9678-8ea2-4249-bcec57521da4@amd.com>
References: <20170916123418.37807-1-brijesh.singh@amd.com>
 <20170916123418.37807-3-brijesh.singh@amd.com>
 <20170917140206.GA4733@nazgul.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org,
        x86@kernel.org, kvm@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Tom Lendacky <thomas.lendacky@amd.com>
To: Borislav Petkov <bp@suse.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20170917140206.GA4733@nazgul.tnic>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 09/17/2017 09:02 AM, Borislav Petkov wrote:
...

>>   
>> +unsigned int sev_enabled __section(.data) = 0;
> 
> static.
> 

Will covert to static in next rev.

...

> 
>> -static inline u64 sme_get_me_mask(void)
>> +static inline bool mem_encrypt_active(void)
>>   {
>> -	return sme_me_mask;
>> +	return !!sme_me_mask;
> 
> As before, you don't need the !!.
> 

Will fix in next rev.
  

thanks