From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH v7 26/26] qmp: add query-sev-launch-measure command
Date: Wed, 7 Feb 2018 12:12:25 -0600
Message-ID: <dce6f9a2-e3e6-b75c-cc34-2fdfc30321f6@amd.com>
References: <20180207160638.98872-1-brijesh.singh@amd.com>
 <20180207160638.98872-26-brijesh.singh@amd.com>
 <14588677-a845-be1e-449f-901ade4a8fe6@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: brijesh.singh@amd.com,
        Alistair Francis <alistair.francis@xilinx.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        "Daniel P . Berrange" <berrange@redhat.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
        Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org,
        Marcel Apfelbaum <marcel@redhat.com>,
        Markus Armbruster <armbru@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Crosthwaite <crosthwaite.peter@gmail.com>,
        Peter Maydell <peter.maydell@linaro.org>,
        Richard Henderson <richard.henderson@linaro.org>,
        Stefan Hajnoczi <stefanha@gmail.com>,
        Thomas Lendacky <Thomas.Lendacky@amd.com>,
        Borislav Petkov <bp@su
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-by2nam01on0080.outbound.protection.outlook.com ([104.47.34.80]:8018
        "EHLO NAM01-BY2-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754038AbeBGSMg (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 7 Feb 2018 13:12:36 -0500
In-Reply-To: <14588677-a845-be1e-449f-901ade4a8fe6@redhat.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 02/07/2018 10:29 AM, Eric Blake wrote:
...

>> +#
>> +# Since: 2.12
>> +#
>> +# Notes: If measurement is not available then a null measurement is 
>> returned.
> 
> Null measurement, as in empty string?  Would it be better to have 
> query-sev-launch-measure return an error instead of an 
> SevLaunchMeasureInfo with a null measurement in that case?
> 

Yes, an empty string when measurement is not available. I can certainly 
change it to return an error when measurement is not available.


>> +##
>> +{ 'struct': 'SevLaunchMeasureInfo', 'data': {'data': 'str'} }
>> +
>> +##
>> +# @query-sev-launch-measure:
>> +#
>> +# Query the SEV guest launch information.
>> +#
>> +# Returns: The @SevLaunchMeasureInfo for the guest
>> +#
>> +# Since: 2.12
>> +#
>> +# Example:
>> +#
>> +# -> { "execute": "query-sev-launch-measure" }
>> +# <- { "return": { "data": "4l8LXeNlSPUDlXPJG5966/8%YZ" } }
>> +#
> 
>