public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Bilbao <carlos.bilbao@amd.com>
To: tglx@linutronix.de, bp@alien8.de, mingo@redhat.com,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	venu.busireddy@oracle.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>, bilbao@vt.edu
Subject: Re: [PATCH] KVM: SVM: Fix reserved fields of struct sev_es_save_area
Date: Tue, 4 Oct 2022 09:28:24 -0500	[thread overview]
Message-ID: <dd357565-d428-499f-fa0e-e35aa043449f@amd.com> (raw)
In-Reply-To: <986a5886-4ddc-aa88-db52-e8781ec95aed@amd.com>

On 10/4/22 09:05, Carlos Bilbao wrote:

> Reserved fields of struct sev_es_save_area are named by their order of
> appearance, but right now they jump from reserved_5 to reserved_7. Rename
> them with the correct order.
>
> Fixes: 6d3b3d34e39eb ("KVM: SVM: Update the SEV-ES save area mapping")
Actually, there is no bug, so this Fix tag could go. Thanks!!
>
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
>  arch/x86/include/asm/svm.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> index 0361626841bc..6ab45a0389dc 100644
> --- a/arch/x86/include/asm/svm.h
> +++ b/arch/x86/include/asm/svm.h
> @@ -393,14 +393,14 @@ struct sev_es_save_area {
>      u64 br_to;
>      u64 last_excp_from;
>      u64 last_excp_to;
> -    u8 reserved_7[80];
> +    u8 reserved_6[80];
>      u32 pkru;
> -    u8 reserved_8[20];
> -    u64 reserved_9;        /* rax already available at 0x01f8 */
> +    u8 reserved_7[20];
> +    u64 reserved_8;        /* rax already available at 0x01f8 */
>      u64 rcx;
>      u64 rdx;
>      u64 rbx;
> -    u64 reserved_10;    /* rsp already available at 0x01d8 */
> +    u64 reserved_9;    /* rsp already available at 0x01d8 */
>      u64 rbp;
>      u64 rsi;
>      u64 rdi;
> @@ -412,7 +412,7 @@ struct sev_es_save_area {
>      u64 r13;
>      u64 r14;
>      u64 r15;
> -    u8 reserved_11[16];
> +    u8 reserved_10[16];
>      u64 guest_exit_info_1;
>      u64 guest_exit_info_2;
>      u64 guest_exit_int_info;
> @@ -425,7 +425,7 @@ struct sev_es_save_area {
>      u64 pcpu_id;
>      u64 event_inj;
>      u64 xcr0;
> -    u8 reserved_12[16];
> +    u8 reserved_11[16];
>
>      /* Floating point area */
>      u64 x87_dp;

  reply	other threads:[~2022-10-04 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 14:05 [PATCH] KVM: SVM: Fix reserved fields of struct sev_es_save_area Carlos Bilbao
2022-10-04 14:28 ` Carlos Bilbao [this message]
2022-10-04 16:29   ` Sean Christopherson
2022-10-04 17:12     ` Carlos Bilbao
2022-10-04 18:51       ` Sean Christopherson
2022-10-04 19:06         ` Carlos Bilbao
2022-10-22  7:46     ` Paolo Bonzini
2022-10-24 16:35       ` Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd357565-d428-499f-fa0e-e35aa043449f@amd.com \
    --to=carlos.bilbao@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=bilbao@vt.edu \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=venu.busireddy@oracle.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox