Re: [PATCH v6 01/11] iommu: Add dma ownership management interfaces

Lu Baolu
2022-02-21T04:03:37Z

On 2/19/22 3:31 PM, Christoph Hellwig wrote:
> The overall API and patch looks fine, but:
>
>> + * iommu_group_dma_owner_claimed() - Query group dma ownership status
>> + * @group: The group.
>> + *
>> + * This provides status query on a given group. It is racey and only for
>> + * non-binding status reporting.
>
> s/racey/racy/

Yes.

>
>> + */
>> +bool iommu_group_dma_owner_claimed(struct iommu_group *group)
>> +{
>> + unsigned int user;
>> +
>> + mutex_lock(&group->mutex);
>> + user = group->owner_cnt;
>> + mutex_unlock(&group->mutex);
>> +
>> + return user;
>> +}
>> +EXPORT_SYMBOL_GPL(iommu_group_dma_owner_claimed);
>
> Still no no need for the lock here.

We've discussed this before. I tend to think that is right.

We don't lose anything with this lock held and it also follows the rule
that all accesses to the internal group structure must be done with the
group->mutex held.

Best regards,
baolu