Re: [PATCH v2 1/4] iommu: Introduce the domain op enforce_cache_coherency()

Lu Baolu
2022-04-09T12:44:40Z

On 2022/4/8 16:05, Tian, Kevin wrote:
>> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
>> index 2f9891cb3d0014..1f930c0c225d94 100644
>> --- a/include/linux/intel-iommu.h
>> +++ b/include/linux/intel-iommu.h
>> @@ -540,6 +540,7 @@ struct dmar_domain {
>> u8 has_iotlb_device: 1;
>> u8 iommu_coherency: 1; /* indicate coherency of
>> iommu access */
>> u8 iommu_snooping: 1; /* indicate snooping control
>> feature */
>> + u8 enforce_no_snoop : 1; /* Create IOPTEs with snoop control */
> it reads like no_snoop is the result of the enforcement... Probably
> force_snooping better matches the intention here.

+1

Other changes in iommu/vt-d looks good to me.

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu