From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
dave.hansen@linux.intel.com, seanjc@google.com,
pbonzini@redhat.com, thomas.lendacky@amd.com,
michael.roth@amd.com, stable@kernel.org
Subject: Re: [PATCH v3] x86/sev: Add SEV-SNP guest feature negotiation support
Date: Tue, 3 Jan 2023 08:55:35 +0530 [thread overview]
Message-ID: <de6ecc09-2cb9-3717-5793-f53bd55d2bfd@amd.com> (raw)
In-Reply-To: <Y7Mzk3tDImk46xcu@zn.tnic>
On 03/01/23 01:12, Borislav Petkov wrote:
> On Mon, Jan 02, 2023 at 08:50:23PM +0530, Nikunj A. Dadhania wrote:
>> I think the "why" part depends on the user. Whether or not the user needs a
>> certain feature enabled for the confidential guest.
>>
>> If the cloud provider(hypervisor) enables the feature on user request, the
>> guest terminates with GHCB_SNP_FEAT_NOT_IMPLEMENTED when guest kernel does
>> have corresponding code/implementation.
>
> I think you mean "does not have" here.
Yes, that is correct.
>
> In any case, I think this whole handling of SEV features could go both ways:
>
> * Cloud provider could say: we've enabled features X, Y and Z and if the guest
> doesn't have support for them, then it would fail booting.
>
> There would optimally be some text sowewhere in the cloud provider documentation
> stating why those features are enabled and thus required to be supported by the
> guest.
>
> * Guest owner could require a minimal subset of features which must be present
> in the HV in order to even boot on that HV.
>
> Of course, I'm only speculating here. How it ends up really playing out in
> reality we will have to see...
>
next prev parent reply other threads:[~2023-01-03 3:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 8:38 [PATCH v3] x86/sev: Add SEV-SNP guest feature negotiation support Nikunj A Dadhania
2023-01-02 11:23 ` David Rientjes
2023-01-02 15:20 ` Nikunj A. Dadhania
2023-01-02 19:42 ` Borislav Petkov
2023-01-03 3:25 ` Nikunj A. Dadhania [this message]
2023-01-02 20:02 ` Borislav Petkov
2023-01-03 3:37 ` Nikunj A. Dadhania
2023-01-03 11:29 ` Borislav Petkov
2023-01-03 23:25 ` David Rientjes
2023-01-03 13:40 ` Borislav Petkov
2023-01-04 4:26 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6ecc09-2cb9-3717-5793-f53bd55d2bfd@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox