From: Paolo Bonzini <pbonzini@redhat.com>
To: "Jim Mattson" <jmattson@google.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11]
Date: Wed, 9 Nov 2016 18:14:14 +0100 [thread overview]
Message-ID: <df2c1182-c46e-fcce-c9c6-13a7d6d7460e@redhat.com> (raw)
In-Reply-To: <1478711076-1426-1-git-send-email-jmattson@google.com>
On 09/11/2016 18:04, Jim Mattson wrote:
>
> + best->edx &= ~F(APIC);
> + if (vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE)
> + best->edx |= F(APIC);
> +
> if (apic) {
> if (best->ecx & F(TSC_DEADLINE_TIMER))
> apic->lapic_timer.timer_mode_mask = 3 << 17;
The three new lines should be inside "if (apic)", because you are not
calling kvm_update_cpuid at all in kvm_lapic_set_base's "if (!apic)" case.
Thanks,
Paolo
next prev parent reply other threads:[~2016-11-09 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 22:00 [PATCH] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11] Jim Mattson
2016-11-08 16:33 ` Radim Krčmář
2016-11-09 16:53 ` Jim Mattson
2016-11-09 17:04 ` [PATCH v2] " Jim Mattson
2016-11-09 17:14 ` Paolo Bonzini [this message]
2016-11-09 17:28 ` Jim Mattson
2016-11-09 17:37 ` Paolo Bonzini
2016-11-09 17:41 ` Jim Mattson
2016-11-09 17:43 ` Paolo Bonzini
[not found] ` <CALMp9eRek+NYZJYfT5TwCR+w=1hdS6e-O+Hm_RzF5MCykOHtWA@mail.gmail.com>
2016-11-10 17:18 ` Paolo Bonzini
2016-11-14 18:14 ` [kvm-unit-tests PATCH] x86: Test disabled local APIC Jim Mattson
2016-11-22 13:55 ` Radim Krčmář
2016-11-09 17:50 ` [PATCH v3] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11] Jim Mattson
2016-11-22 13:53 ` Radim Krčmář
2016-11-09 17:15 ` [PATCH v2] " Igor Mammedov
2016-11-09 17:37 ` Eduardo Habkost
2016-11-09 17:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2c1182-c46e-fcce-c9c6-13a7d6d7460e@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).