From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror
 IA32_APIC_BASE[11]
Date: Wed, 9 Nov 2016 18:14:14 +0100
Message-ID: <df2c1182-c46e-fcce-c9c6-13a7d6d7460e@redhat.com>
References: <CALMp9eStHi7-Qhw9uXanBjHpLW0Ce_1HcZdhnDK88hD+p6mWxg@mail.gmail.com>
 <1478711076-1426-1-git-send-email-jmattson@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Jim Mattson <jmattson@google.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f66.google.com ([74.125.82.66]:34746 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751677AbcKIROR (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 9 Nov 2016 12:14:17 -0500
Received: by mail-wm0-f66.google.com with SMTP id p190so30602041wmp.1
        for <kvm@vger.kernel.org>; Wed, 09 Nov 2016 09:14:17 -0800 (PST)
In-Reply-To: <1478711076-1426-1-git-send-email-jmattson@google.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 09/11/2016 18:04, Jim Mattson wrote:
>  
> +	best->edx &= ~F(APIC);
> +	if (vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE)
> +		best->edx |= F(APIC);
> +
>  	if (apic) {
>  		if (best->ecx & F(TSC_DEADLINE_TIMER))
>  			apic->lapic_timer.timer_mode_mask = 3 << 17;

The three new lines should be inside "if (apic)", because you are not
calling kvm_update_cpuid at all in kvm_lapic_set_base's "if (!apic)" case.

Thanks,

Paolo